Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between 'Noise Flag?' and 'Discard last dynamic' checkbox? #12

Open
BenGurer opened this issue Oct 26, 2016 · 2 comments
Open
Assignees

Comments

@BenGurer
Copy link
Contributor

If both 'Noise Flag?' and 'Discard last dynamic' are set to 1, the last two scans will be removed from the tSNR measurement.

@julienbesle
Copy link
Collaborator

julienbesle commented Oct 26, 2016

More generally there seems to be some redundancy between the values set in the GUI scan table and the 'Select dynamics' and 'Discard last dynamic' in the lower panel of the GUI.
Because the table's values (Noise flag, first and last scan) are editable, it gives the impression that they will be taken into account when computing the tSNR (for example for selecting a different range of dynamics). In fact, the first and last scan values are not taken into account... (although the Noise flag is, as pointed out by Ben)
The 'Select dynamics' checkbox and 'Discard last dynamic' button are useful because they allow to change the values for all scans at once, but it would be good to be able to change values individually for each scan.
What about the following: the checkbox and button could be used to set all values in the table at once, which then would be used to set the tSNR parameters (instead of the checkbox and buttons directly setting the parameters; this way, the user can still modify each scan individually in the table and the values in teh table will be the ones actually used)? I can take care of it if you agree

@julienbesle julienbesle self-assigned this Oct 31, 2016
@ppxma7
Copy link
Collaborator

ppxma7 commented Feb 27, 2020

Following the update to an app, I have made the decision to remove the table editability for convenience. In a future update, I will make the table editable to give people the option of having a different set of dynamics for every scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants