-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move debuglog out of diagnostic channels #3809
Comments
I'd prefer to see if we can inline it. The coupling of both concepts seems like a good idea but in reality, they overlap and serve different purposes. |
this was my idea, haven't had time to work on it. It's easy to detect when we're in node core already Lines 68 to 70 in fe1f132
|
I am curious if not PR #3600 introduced this issue. Maybe the old subscribe referred to a separate diagnostic sub channel or so? I mean we had not this issue before?! |
The issue was always there, but we avoided it by disabling global fetch in our tests. This is not possible anymore. |
Unfortunately, using diagnostic channels to set up
debuglog
was a bad idea. It won't work because our implementation inside Node.js will react to the sameNODE_DEBUG
flag, and duplicate the messages, making these logs hard to read.A solution for this would be:
Do you see any other options?
The text was updated successfully, but these errors were encountered: