npm ERR! code ELSPROBLEMS

[richardlau]

I've noticed the "Node.js CI" badge on the README is red (failing):

Clicking on the badge leads to https://github.com/nodejs/citgm/actions?query=workflow%3A%22Node.js+CI%22 and the most recent runs on main are green:

Clicking on one of the green builds shows annotations even though the subjobs are all green:
e.g. https://github.com/nodejs/citgm/actions/runs/6347014207

Clicking on one of the annotations shows that npm is returning exit code 1 in the "Print installed dependencies" step.
e.g. https://github.com/nodejs/citgm/actions/runs/6347014207/job/17241378354#step:12:991

Run npm ls --all
npm ERR! code ELSPROBLEMS
npm ERR! invalid: [email protected] /home/runner/work/citgm/citgm/node_modules/tap/node_modules/wrap-ansi
[email protected] /home/runner/work/citgm/citgm

├── [email protected]
npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2023-09-29T04_03_07_033Z-debug-0.log
...
Error: Process completed with exit code 1.

[richardlau]

It looks like bd92122 was the commit that introduced the problem.

• https://github.com/nodejs/citgm/actions/runs/6126053953 for bd92122 failed with this error.
• https://github.com/nodejs/citgm/actions/runs/6124892514 for the previous commit aa3eaa1 did not.

bd92122 is #966 (cc @anonrig) but AFAICT the problem didn't occur for the commits in that PR (a merge issue?).

[anonrig]

@richardlau Can you reproduce the error locally?

[richardlau]

@anonrig I haven't tried.

[anonrig]

It seems to be the issue caused by pkgjs/action - https://github.com/pkgjs/action/blob/main/package.json#L8.

npm test || exit 1 could be the reason.

@isaacs did node-tap change it's exit code?

[ljharb]

npm ls is a good thing to check, and fails when the dep graph is invalid. Extraneous or missing deps can cause it. It’s best to fix the underlying problem.

[targos]

This seems like an npm tree optimization bug. node_modules/tap/node_modules/cliui wants wrap-ansi@^7.0.0, but npm installed [email protected] in node_modules/tap/node_modules/wrap-ansi.

I opened npm/cli#6856

[anonrig]

Should we disable npm ls --all command until it's fixed upstream?