Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch correct in RAN data? #69

Open
nilsbore opened this issue Sep 8, 2020 · 5 comments · May be fixed by #95
Open

Pitch correct in RAN data? #69

nilsbore opened this issue Sep 8, 2020 · 5 comments · May be fixed by #95

Comments

@nilsbore
Copy link
Owner

nilsbore commented Sep 8, 2020

We should see if the conversion between NED and ENU coordinate system invalidates some of the pitch readings.

Basically, the heading/yaw should already be correct. The roll is the same AFAIK. However, the pitch needs to be negated. I don't know right know how this is handled for the .all and .xtf files from RAN. Maybe @xyp8023 can look into it if he's looking at the RAN data now.

@xyp8023
Copy link
Contributor

xyp8023 commented Sep 14, 2020

According to the .xtf data format specifications, for pitch, positive value is nose up. According to the .all data format specifications, Pitch is positive with bow up. Then I think we are all set, they are both using ENU, as far as I understand.

@nilsbore
Copy link
Owner Author

In that case, they are using NED. Positive angles should be nose pitching down in ENU.

@nilsbore
Copy link
Owner Author

I wonder if we should just transition all of auvlib to use NED instead, since that is what all the formats are using. Any thoughts? It would be a pretty big undertaking.

@xyp8023
Copy link
Contributor

xyp8023 commented Sep 14, 2020

Probably that'd be for the best if all underwater community are using NED. Saves us some effort in the future.

@nilsbore
Copy link
Owner Author

Added point to 1.0 goal: #49

xyp8023 added a commit to xyp8023/auvlib that referenced this issue Oct 23, 2024
…every data format, since marine people all use NED convention, and in auvlib we use ENU. The heading should already be correct, and the roll is the same, discussion see ISSUE nilsbore#69
@xyp8023 xyp8023 linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants