Support aliases in gbasf2 batch #40
Conversation
|
The only thing that I see might be fishy with this solutions, is, that the aliases are taken from VariableManager singleton and thus are specific to the basf2 state. That is, variables added to one task will probably also be added to all tasks afterwards that are processed by the same worker, as far as I understand. But I don't see much danger with that, except when people use different alias values for the same alias names (keys) in different tasks. I just checked that there's no bugs when people add the same alias multiple times, but then it's still only once in the variable manager, so there is no danger in that. |
|
Sorry the review took so long, looks very good to me. Thanks, @meliache! |
Sam Cunliffe was so nice to tell me how to extract alias values, not just their names, from the variable manager (b2question link. With that it was pretty easy to store them also in the pickle and reapply them on the grid. I tested it and it seems to work nicely.
I now you suggested to look at
pickable_basf2.pyto store the basf2 calls, but the variables wouldn't be pickled as far as I know except if you wrap them inmake_code_pickable. And to be honest I couldn't figure out yet how to use the code frompickable_basf2for my use-case yet.