Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled rich text editor tests on WebKit #1938

Open
jattasNI opened this issue Mar 15, 2024 · 3 comments
Open

Disabled rich text editor tests on WebKit #1938

jattasNI opened this issue Mar 15, 2024 · 3 comments
Labels
blocked Blocked on a third-party issue tech debt

Comments

@jattasNI
Copy link
Contributor

jattasNI commented Mar 15, 2024 •
edited
Loading

🧹 Tech Debt

Several rich text editor and markdown serializer tests fail on webkit with the error:
TypeError: undefined is not an object (evaluating 'found.startContainer') thrown

The tests have been disabled on Webkit. Search source for this bug ID to find them.

Corresponding AzDO bug filed to owning team. Bug 2684311: Nimble rich text editor tests failing in WebKit / Safari and have been disabled

This still needs to be debugged and reported to an upstream dependency (probably Prosemirror)
@jattasNI jattasNI added tech debt triage New issue that needs to be reviewed labels Mar 15, 2024
This was referenced Mar 15, 2024
Closed
Merged
@jattasNI jattasNI changed the title Disabled rich text editor tests on Webkit Disabled rich text editor tests on WebKit Mar 18, 2024
@rajsite
Copy link
Member

rajsite commented Mar 18, 2024

@jattasNI assigning to you for filing the AzDo bug since it's marked as TODO for that step

rajsite added a commit that referenced this issue Mar 18, 2024
@jattasNI @rajsite
Disable and tag tests failing in specific browsers (#1941)
a112528 
# Pull Request

## 🤨 Rationale

One of the tasks in #1747 is to run nimble-components tests in WebKit
and see if there are any new failures. There are several.

We also wanted to start tracking specific issues for each root cause
rather than catch all issues like #1074 and #1075.

## 👩‍💻 Implementation

Marked each failing test with one of these specific issues:
- #1936
- #1938 TODO: ALSO FILE AZDO BUG
- #1939 
- #1940 
- #1942 
- #1943

Also re-enabled a couple of table header tests in Firefox which are now
passing.

## 🧪 Testing

Ran tests in Playwright webkit browser, Firefox, and Safari and and all
the enabled tests now pass.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
@jattasNI jattasNI removed their assignment Mar 18, 2024
@jattasNI
Copy link
Contributor Author

AzDO bug filed Bug 2684311: Nimble rich text editor tests failing in WebKit / Safari and have been disabled

@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Mar 19, 2024
@jattasNI jattasNI moved this from Backlog to Defined/Ready to Pickup in Nimble Design System Priorities Mar 27, 2024
@aagash-ni
Copy link
Contributor

Marking this as blocked as there is an issue with prosemirror-view package

While looking into this issue, it appears that using the Tiptap editor (within a shadow DOM) in Safari/WebKit, executing a hard break (Shift + Enter) is breaking inside the prosemirror-view package. Created issue in tiptap and prosemirror

Tiptap issue: ueberdosis/tiptap#5026
Prosemirror issue: ProseMirror/prosemirror#1454

@aagash-ni aagash-ni added the blocked Blocked on a third-party issue label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked on a third-party issue tech debt
Projects
Nimble Design System Priorities
Status: Defined/Ready to Pickup
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rajsite @m-akinc @jattasNI @aagash-ni