Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change to tox-gh? #60

Open
sfmig opened this issue Aug 5, 2024 · 2 comments
Open

Should we change to tox-gh? #60

sfmig opened this issue Aug 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sfmig
Copy link
Contributor

sfmig commented Aug 5, 2024

Is your feature request related to a problem? Please describe.
Should we change tox-gh-action in our tests workflow, to tox-gh?

There are no current issues with tox-gh-action, but we may want to consider switching to tox-gh since it is part of the tox organisation and seems a bit more actively maintained.

Describe the solution you'd like
The downside is if we go for tox-gh we would need to change (albeit slightly) the tox section of the pyproject.toml.

Describe alternatives you've considered
We can just stay as is.

Additional context
\

@sfmig sfmig added the enhancement New feature or request label Aug 5, 2024
@alessandrofelder
Copy link
Member

Would this mean editing the pyproject.toml file for each repo? I could be tempted to do this if the reason was slightly more strong (like tox-gh-action not being maintained at all, versus slightly less maintained) if that makes sense?

@sfmig
Copy link
Contributor Author

sfmig commented Aug 9, 2024

Yeah I agree

EDIT: But at the same time this feels like the kind of problem that will be more annoying with time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants