undefined reference to `gem5::GshareBPParams::create() const

[akhil-deshneni]

I have followed the instructions laid out in readme and while reconstructing the source using scons getting the below error:

/usr/bin/ld: build/X86/python/_m5/param_GshareBP.o: in function void pybind11::cpp_function::initialize<pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}, gem5::branch_prediction::GshareBP*, gem5::GshareBPParams const*, pybind11::name, pybind11::is_method, pybind11::sibling>(pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}&&, gem5::branch_prediction::GshareBP* (*)(gem5::GshareBPParams const*), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)': /home/akhil/gem_5/gem5/ext/pybind11/include/pybind11/pybind11.h:223: undefined reference to gem5::GshareBPParams::create() const'
collect2: error: ld returned 1 exit status
scons: *** [build/X86/gem5.opt] Error 1
scons: building terminated because of errors.

[akhil-deshneni]

How to resolve this issue any insights are highly appreciated

[chnjstyj]

I modified the gshare.cc & gshare.hh by changing

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed);

to

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed, const StaticInstPtr &inst, Addr corrTarget);
in .hh .
At the same time modify the function signatures in .cc
After that ran scons command to rebuild the gem5 and got successful result.

[baul-iisc]

I modified the gshare.cc & gshare.hh by changing

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed);

to

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed, const StaticInstPtr &inst, Addr corrTarget); in .hh . At the same time modify the function signatures in .cc After that ran scons command to rebuild the gem5 and got successful result.

With the above corrections also, the same error is repeating, please suggest how to address the following errors, [ LINK] -> RISCV/gem5.opt
/usr/bin/ld: build/RISCV/python/_m5/param_GshareBP.o: in function void pybind11::cpp_function::initialize<pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}, gem5::branch_prediction::GshareBP*, gem5::GshareBPParams const*, pybind11::name, pybind11::is_method, pybind11::sibling>(pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}&&, gem5::branch_prediction::GshareBP* (*)(gem5::GshareBPParams const*), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)': /development/gem5-riscv/gem5/ext/pybind11/include/pybind11/pybind11.h:223: undefined reference to gem5::GshareBPParams::create() const'
collect2: error: ld returned 1 exit status
scons: *** [build/RISCV/gem5.opt] Error 1
scons: building terminated because of errors.

[baul-iisc]

I have followed the instructions laid out in readme and while reconstructing the source using scons getting the below error:

/usr/bin/ld: build/X86/python/_m5/param_GshareBP.o: in function void pybind11::cpp_function::initialize<pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}, gem5::branch_prediction::GshareBP*, gem5::GshareBPParams const*, pybind11::name, pybind11::is_method, pybind11::sibling>(pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}&&, gem5::branch_prediction::GshareBP* (*)(gem5::GshareBPParams const*), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)': /home/akhil/gem_5/gem5/ext/pybind11/include/pybind11/pybind11.h:223: undefined reference to gem5::GshareBPParams::create() const' collect2: error: ld returned 1 exit status scons: *** [build/X86/gem5.opt] Error 1 scons: building terminated because of errors.

Hay! are you able to resolve this issue? if so please suggest the correction required!

[chnjstyj]

I modified the gshare.cc & gshare.hh by changing
void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed);
to
void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed, const StaticInstPtr &inst, Addr corrTarget); in .hh . At the same time modify the function signatures in .cc After that ran scons command to rebuild the gem5 and got successful result.

With the above corrections also, the same error is repeating, please suggest how to address the following errors, [ LINK] -> RISCV/gem5.opt /usr/bin/ld: build/RISCV/python/_m5/param_GshareBP.o: in function void pybind11::cpp_function::initialize<pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}, gem5::branch_prediction::GshareBP*, gem5::GshareBPParams const*, pybind11::name, pybind11::is_method, pybind11::sibling>(pybind11::cpp_function::initialize<gem5::branch_prediction::GshareBP*, gem5::GshareBPParams, , pybind11::name, pybind11::is_method, pybind11::sibling>(gem5::branch_prediction::GshareBP* (gem5::GshareBPParams::*)() const, pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)::{lambda(gem5::GshareBPParams const*)#1}&&, gem5::branch_prediction::GshareBP* (*)(gem5::GshareBPParams const*), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&)': /development/gem5-riscv/gem5/ext/pybind11/include/pybind11/pybind11.h:223: undefined reference to gem5::GshareBPParams::create() const' collect2: error: ld returned 1 exit status scons: *** [build/RISCV/gem5.opt] Error 1 scons: building terminated because of errors.

I guess the problem is some functions' signature in source code is different from the newest gem5 predictor. You can check it with your own gem5 example predictor function signature and fix the differences.

[amunlau]

I modified the gshare.cc & gshare.hh by changing

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed);

to

void update(ThreadID tid, Addr branch_addr, bool taken, void *bp_history, bool squashed, const StaticInstPtr &inst, Addr corrTarget); in .hh . At the same time modify the function signatures in .cc After that ran scons command to rebuild the gem5 and got successful result.

The issue of "undefined reference to gem5::GshareBPParams::create() const" still hasn't been resolved. Has anyone found a solution? I would appreciate it if you could share the fix.