-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orthology associations not very helpful without taxon info #227
Comments
I should have looked at v3, it looks like it'll be another column which means I need to prioritize monarch-initiative/monarch-ingest#485 |
I'm adding this as an extra table column in the table view. But should we add this to the summary view? |
This was at least added to the table view for associations: For summary, if gene names/symbols are truly not helpful at all without the taxon, maybe I could put the taxon in parenthesis immediately after, and not bolded. Eg: "Pax2 (sus scrofa)". |
There's a little bit of information in the capitalization of gene names (human is always all caps, mouse/rat/? is capitalized first letter), but I do think that putting the taxon info right in the name/link definitely fits the use case nicely of why somebody would look at orthology associations. |
Closes #266 Closes #227 Closes #77 Closes #80 Summary of changes (for reviewers, going commit by commit is better for this PR): - rework 404 redirect - add "BETA" to prod banner - update category icons - change css data attr selectors to class selectors - show taxon info in node badge for genes - in node badge, remove link option. instead, show link unless already on page being linked to (current node). - rework and reinsert breadcrumbs, but only hook up to hierarchy - refactor predicate badge - dont automatically change case of labels in select components, do that from parent using it - in multi select component, solo-select first option clicked - add icon support to multi select component - in select components, fix hover then enter press bug - tweak table component styling, save expanded state to local storage - fix tab component keyboard wrapping behavior - add search box to header and change styles to accommodate - tweak homepage nexus visualization - on testbed, show all custom icons - change tab search higher-order-component to accommodate search box in header - re-add breadcrumbs section - add "back to search" button at top of node page
We need to figure out how to include some taxon info here.
It could be that we put taxon info on the edge (and we may need to do that for other reasons) and then use that taxon id & label in a column.
We could also take an approach of doing something like putting taxon info into the subject_label or object_label as necessary - so that
pax2
for pig would look likepax2 (sus scrofa)
- I think this is interesting because we could actually put that into the name field on the entity.The text was updated successfully, but these errors were encountered: