[DRAFT] feat(github): add code for listing/reviewing/getting PRs on Github #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRaduan
commented
Dec 11, 2024
| @@ -706,7 +709,7 @@ async function getIssue( | |||
| "User-Agent": "github-mcp-server", | |||
| }, | |||
| } | |||
| ); | |||
| ); | |||
| @@ -299,7 +299,7 @@ export const GitHubPullRequestSchema = z.object({ | |||
| locked: z.boolean(), | |||
| title: z.string(), | |||
| user: GitHubIssueAssigneeSchema, | |||
| body: z.string(), | |||
| body: z.string().nullable(), | |||
There was a problem hiding this comment.
I started noticing that body can be nullable across multiple schemas on LIST api requests for GitHub API. JFYI.
Comment on lines
+717
to
+722
| export const GetPullRequestDiffSchema = z.object({ | ||
| owner: z.string().describe("Repository owner (username or organization)"), | ||
| repo: z.string().describe("Repository name"), | ||
| pull_number: z.number().describe("Pull request number"), | ||
| }); | ||
|
|
There was a problem hiding this comment.
This is not finished yet.
Comment on lines
+1167
to
+1172
| case "get_pull_request_diff": { | ||
| const args = GetPullRequestDiffSchema.parse(request.params.arguments); | ||
| const diff = await getPullRequestDiff(args.owner, args.repo, args.pull_number); | ||
| return { toolResult: diff }; | ||
| } | ||
|
|
There was a problem hiding this comment.
not finished/tested yet.
| export type ReviewPullRequest = z.infer<typeof ReviewPullRequestSchema>; | ||
| export type SearchCode = z.infer<typeof SearchCodeSchema>; | ||
| export type SearchIssues = z.infer<typeof SearchIssuesSchema>; | ||
| export type SearchUsers = z.infer<typeof SearchUsersSchema>; |
There was a problem hiding this comment.
TODO: add line to the end
Comment on lines
+763
to
+764
| export type SearchCode = z.infer<typeof SearchCodeSchema>; | ||
| export type SearchIssues = z.infer<typeof SearchIssuesSchema>; |
There was a problem hiding this comment.
I am not sure if those types are actually used, todo: verify
|
Thanks! Converting this to a draft to make its status clear. Please mark as "ready for review" when you'd like us to take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding functionality to List, Review and Get info on Github PRs.
Pending adding functionality to get PR diffs(right now it's not returned). Will mark as ready once finishing that.
Server Details
githubtoolsMotivation and Context
Thought of adding functionality to review and list PRs on private/public repos on Github.
How Has This Been Tested?
Verified manually via Claude Desktop.
Breaking Changes
None.
Types of changes
Checklist
Additional context
n/a