New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anti-pattern: API must have client-agnostic representation #1305

Open

sldblog opened this issue Nov 8, 2022 · 0 comments

Labels

Contributor

sldblog commented Nov 8, 2022 •

edited

Loading

hmpps-interventions-service/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsinterventionsservice/dto/ChangelogValuesDTO.kt

Lines 31 to 32 in cb53f27

    
           fun from(changelog: Changelog, userDetail: UserDetail): ChangelogValuesDTO { 
        
             val dateTimeFormatter = DateTimeFormatter.ofPattern("dd MMM yyyy 'at' h.mma")

Avoid: non-standard, human-readable representation of values

Do: use standard representation (ISO8601) and delegate formatting to the API client

sldblog changed the title ~~API must have client-agnostic representation~~ Anti-pattern: API must have client-agnostic representation

sldblog added the code-smell label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment