Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine all Minder PR comments into a single comment #5119

Open
eleftherias opened this issue Dec 3, 2024 · 1 comment · May be fixed by #5182
Open

Combine all Minder PR comments into a single comment #5119

eleftherias opened this issue Dec 3, 2024 · 1 comment · May be fixed by #5182
Assignees
@JAORMX

Comments

@eleftherias
Copy link
Contributor

When a new PR comment is added, we should combine it with existing comments from other rules, rather than having Minder create separate comments for each rule.

Out of scope:

  • Gitlab
@eleftherias eleftherias mentioned this issue Dec 3, 2024
Closed
3 tasks
@JAORMX JAORMX self-assigned this Dec 4, 2024
@evankanderson
Copy link
Member

@ethomson points out a concern about rule evaluations completing on different time schedules:

If license scanning takes 100ms and static analysis takes 5 minutes, do we add the license scan report right away and then update the comment later when static analysis comes in?

@JAORMX JAORMX linked a pull request Dec 11, 2024 that will close this issue
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JAORMX JAORMX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a shared actions context structure JAORMX/minder
3 participants
@JAORMX @eleftherias @evankanderson