Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Stremio.StremioService version 0.1.13 #199300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New package: Stremio.StremioService version 0.1.13 #199300

wants to merge 2 commits into from
+58 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 17, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Console logs 
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 0.1.13

Found Stremio Service [Stremio.StremioService] Version 0.1.13
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.VCRedist.2015+.x64
(1/1) Found Microsoft Visual C++ 2015-2022 Redistributable (x64) [Microsoft.VCRedist.2015+.x64] Version 14.42.34433.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/c7dac50a-e3e8-40f6-bbb2-9cc4e3dfcabe/1821577409C35B2B9505AC833E246376CC68A8262972100444010B57226F0940/VC_redist.x64.exe
  ██████████████████████████████  24.4 MB / 24.4 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://dl.strem.io/stremio-service/v0.1.13/StremioServiceSetup.exe
  ██████████████████████████████  34.9 MB / 34.9 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                                                        DisplayVersion Publisher             ProductCode                                Scope
-----------                                                        -------------- ---------             -----------                                -----
Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.42.34433 14.42.34433.0  Microsoft Corporation {804e7d66-ccc2-4c12-84ba-476da31d103d}     Mac...
Stremio Service version 0.1.13                                     0.1.13         Smart Code OOD        {DD3870DA-AF3C-4C73-B010-72944AB610C6}_is1 User


PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> Get-ARPTable | Format-Table

DisplayName                                                        DisplayVersion Publisher             ProductCode                                Scope
-----------                                                        -------------- ---------             -----------                                -----
Microsoft Edge                                                     100.0.1185.36  Microsoft Corporation Microsoft Edge                             Machine
Microsoft Edge Update                                              1.3.155.85                           Microsoft Edge Update                      Machine
Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.42.34433 14.42.34433.0  Microsoft Corporation {804e7d66-ccc2-4c12-84ba-476da31d103d}     Machine
Stremio Service version 0.1.13                                     0.1.13         Smart Code OOD        {DD3870DA-AF3C-4C73-B010-72944AB610C6}_is1 User
Screenshots

image

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 17, 2024
stephengillie
stephengillie requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the other download page is the company's official page, it doesn't list the service. But this page does.

manifests/s/Stremio/StremioService/0.1.13/Stremio.StremioService.locale.en-US.yaml Outdated Show resolved Hide resolved
@Dragon1573 @stephengillie
Apply suggestions from code review
830ec7b 
- Change `PackageUrl`

Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Domain Changes-Requested Changes Requested New-Package labels Dec 18, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Dec 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 18, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Dragon1573 Dragon1573

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: Stremio.StremioService
3 participants
@Dragon1573 @wingetbot @stephengillie