Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot leave comments on hunks in large diffs #6524

Open
aursulis opened this issue Dec 10, 2024 · 2 comments
Open

Cannot leave comments on hunks in large diffs #6524

aursulis opened this issue Dec 10, 2024 · 2 comments
Labels
info-needed Issue requires more information from poster

Comments

@aursulis
Copy link

  • Extension version: v0.100.3
  • VSCode Version: 1.95.3 (system setup)
  • OS: Windows_NT x64 10.0.19045
  • Repository Clone Configuration (single repository/fork of an upstream repository): single
  • Github Product (Github.com/Github Enterprise version x.x.x): Github Enterprise Server 3.12.9

Steps to Reproduce:

Checkout a pull request that contains large diffs (ones which Github renders as "Load diff / Large diffs are not rendered by default"). Open that large diff as a side-by-side view:

  • the line in the gutter showing where you can leave comments is not displayed
  • hovering over the gutter on changed lines does not display the comment button
  • however, comments made via the Github UI are visible

I don't have any PR to hand to demonstrate as I'm using this with a Github Enterprise Server, but would be happy to make a fake one on GH if needed.

@alexr00
Copy link
Member

alexr00 commented Dec 13, 2024

I conveniently just made #6536, and there's a large diff file there.

I'm not able to repro the issue. Do you see the issue with that file?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Dec 13, 2024
@aursulis
Copy link
Author

aursulis commented Dec 13, 2024

No, indeed I can't see the issue with that file. I've made aursulis/test-repo-1#1 which reproduces it for me.

So maybe something to do with the number of hunks, or lines changed? For reference, the (non-contrived) PR I encountered this on had 171 1-line changes in a file. 35 spaced out by 12 lines, and the rest separated by 2 or 4 lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants
@aursulis @alexr00 and others