Make MSTest.Analyzers a dependency of MSTest.TestFramework

[Evangelink]

Summary

Make MSTest.Analyzers a dependency of MSTest.TestFramework.

Background and Motivation

MSTest.Analyzers currently exists but it is nearly not downloaded compared to the framework and I think we should have a 1:1 ratio as it brings only added value and no defaults. I have checked there is no impact for F# users.

Proposed Feature

Make MSTest.Analyzers a dependency of MSTest.TestFramework.

Before:

<PackageReference Include="MSTest.TestFramework" />
<PackageReference Include="MSTest.Analyzers" />

After:

<PackageReference Include="MSTest.TestFramework" />

For users relying on MSTest metapackage or MSTest.Sdk it would be a transparent update.

Alternative Designs

We could avoid extra package deps and directly include the analyzer dlls into MSTest.TestFramework but this would cause confusion and potential errors for users who are using MSTest.Analyzers today. It would also make it out of sync in term of versioning.

[Evangelink]

Closing as the idea is mainly not liked internally.