TestClassAttribute inheritance is inconsistent

[Youssef1313]

namespace TestProject9;

[TestClass]
public class Test1
{
    [TestMethod]
    public void TestMethod1()
    {
        // Called. Correct behavior.
    }
}

public class Test2 : Test1
{
    [AssemblyInitialize]
    public static void AsmInit2(TestContext _)
    {
        // Called. Unexpected behavior.
    }

    [ClassInitialize]
    public static void ClassInit2(TestContext testContext)
    {
        // Not Called. Correct behavior.
    }

    [TestMethod]
    public void TestMethod2()
    {
        // Not called. Correct behavior
    }
}

Root cause seems to be:

testfx/src/Adapter/MSTest.TestAdapter/Execution/TypeCache.cs

Line 414 in 97cb7b4

if (!_reflectionHelper.IsDerivedAttributeDefined<TestClassAttribute>(t, inherit: true))

[Evangelink]

These bugs of derived vs non derived are endless..

[Youssef1313]

@Evangelink Willing to take a break here to fix this in minor version or should it be v4?

[Evangelink]

Sounds like a bug in the wanted/documented/expected behavior so I am fine to fix it.

PS: I think the ticket title should be "inconsistent".

[Youssef1313]

PS: I think the ticket title should be "inconsistent".

Yup! Fixed the title.

[Youssef1313]

@Evangelink I added to 3.8 milestone. Feel free to move/remove accordingly.