Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger interface and not EqtTrace logger #2140

Open
Evangelink opened this issue Jan 22, 2024 · 1 comment
Open

Use logger interface and not EqtTrace logger #2140

Evangelink opened this issue Jan 22, 2024 · 1 comment

Comments

@Evangelink
Copy link
Member

Summary

MSTest is currently using eqt trace logger everywhere for technical logs. This is preventing any logs to be produced when working in runner mode. There is also many limitations to how EqtTrace works that can cause locks and slowness.

Instead we should flow some interface and change the logger based on the actual runner.

@nohwnd
Copy link
Member

nohwnd commented Jan 23, 2024

more reasoning for history:

vstest/src/Microsoft.TestPlatform.PlatformAbstractions/common/Tracing/PlatformEqtTrace.cs at main · microsoft/vstest (github.com) It is probably for the best if you replace all the references to eqttrace in mstest with a logger interface that will forward to eqttrace, and that is defined in mstest.framework.

  1. eqttrace is in objectmodel, and so this logging is only available to adapter, instead it should be available everywhere in mstest, so we can log any info from anywhere.
  2. eqttrace owns the file and rolls it when it reaches given size. and it also won't allow writing into the file from multiple places without lock issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants