Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename vstest-filter to just filter #2002

Closed
jpribele opened this issue Dec 22, 2023 · 3 comments
Closed

rename vstest-filter to just filter #2002

jpribele opened this issue Dec 22, 2023 · 3 comments
Assignees
Milestone

Comments

@jpribele
Copy link

jpribele commented Dec 22, 2023

Summary

Its a bit weird that is different. the docs reference in the command line output says filter

Background and Motivation

easier to use. don't need to switch arguments when changing between the two runners

AB#1934380

@Evangelink
Copy link
Member

The main motivation for this new wording was that we wanted to introduce a new filter system by default (this had to be postponed) because there are many confusions around the vstest filter between the various test frameworks.

I'll keep this open so we can decide if we will manage to implement the new filter quickly and so it might be worth to keep current shape or if we think this will be delayed and it's better to change.

Please if you have any other feedback let us know this is super valuable for us to be able to fine tune the runner.

@Evangelink
Copy link
Member

Hey @jpribele! We had a quick chat with the team and we decided to rename the filter and the runsettings command line options to match those of dotnet test command

@Evangelink
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants