Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS] Add GitHub Support to fabric_workspace_git #112

Open
1 task done
SemUijen opened this issue Nov 27, 2024 · 4 comments
Open
1 task done

[RS] Add GitHub Support to fabric_workspace_git #112

SemUijen opened this issue Nov 27, 2024 · 4 comments
Labels
feature New feature or request

Comments

@SemUijen
Copy link

SemUijen commented Nov 27, 2024

🚀 Feature description

Adding support for GitHub for the fabric_workspace_git resource.

  1. As git_provider_type

🔈 Motivation

Currently only AzureDevOps is supported #108 . For us it is a standard way of working to use Github and for some of our clients its a must.

🛰 Alternatives

A second approach to add GitHub support is to have separate resources for github and Azure Devops

🚧 Potential Configuration / Desired Solution

Option 1:

resource "fabric_workspace_git" "example" {
  workspace_id            = "id"
  initialization_strategy = ""
  git_provider_details = {
    git_provider_type = "GitHub"
    repository_name   = "example"
    branch_name       = "example"
    directory_name    = "example"
    owner_name = "example"
  }
}

or
Option 1:

resource "fabric_workspace_github" "example" {
  workspace_id            = "id"
  initialization_strategy = ""
  git_provider_details = {
    repository_name   = "example"
    branch_name       = "example"
    directory_name    = "example"
    owner_name = "example"
  }
}

📎 Additional context

I saw that contribution(PRs) currently won't be accepted. Is this feature by any chance already in development? otherwise I would like to add it myself if possible 😄

🔰 Code of Conduct

  • I agree to follow this project's Code of Conduct.
@SemUijen SemUijen added the feature New feature or request label Nov 27, 2024
@DariuszPorowski
Copy link
Member

DariuszPorowski commented Dec 2, 2024

Hi @SemUijen

GitHub integration API uses "connection ID" based on Connections API (https://learn.microsoft.com/en-us/rest/api/fabric/core/connections), so adding this resource requires connection resource implementation in the Provider first as a dependency.

Connections API is in preview, and that blocks us to onboard to the Provider - currently, only APIs that are GA will be added on an ongoing basis. Once Connections API gets GA, we will start working on the connection resource which will unlock the addition of GitHub.

@DariuszPorowski DariuszPorowski changed the title [feature] Add GitHub Support to fabric_workspace_git [RS] Add GitHub Support to fabric_workspace_git Dec 9, 2024
@SemUijen
Copy link
Author

Hi @DariuszPorowski It makes sense that you are not implementing non-GA APIs. Do you have an idea of when these APIs will be GA?
Will this be Q1 or later?

@DariuszPorowski
Copy link
Member

@SemUijen ETA unknown for now, especially Connections API has been released as Public Preview ~1 mo ago, so do not expect to have GA in Q1 in that short period of time.

@SemUijen
Copy link
Author

@DariuszPorowski Thx for quick update! I will build a temporary solution for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants