Fix ValueError in dump_bin.py by excluding 'symbol' field from conversion #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Fixes microsoft#1852 Modify `scripts/dump_bin.py` to handle the conversion of string 'SH600000' to float correctly. * **Exclude 'symbol' field from conversion**: - Modify `_data_to_bin` method to exclude the 'symbol' field from conversion to float. - Add a check to ensure 'symbol' field is not included in the fields to be converted. * **Update `normalize_data` method**: - Ensure `normalize_data` method in `scripts/data_collector/baostock_5min/collector.py` processes data correctly without converting 'symbol' to float. - Update `normalize_baostock` method to retain 'symbol' field as a string. * **Documentation update**: - Emphasize the importance of `normalize_data` before using `dump_bin.py` in `scripts/data_collector/baostock_5min/README.md`.
github-actions
bot
added
documentation
|
@microsoft-github-policy-service agree |
|
We would like to understand what the purpose of this change is, I understand that if the data is normalized before dump_bin, the symbol field will not appear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1852
Modify
scripts/dump_bin.pyto handle the conversion of string 'SH600000' to float correctly.Exclude 'symbol' field from conversion:
_data_to_binmethod to exclude the 'symbol' field from conversion to float.Update
normalize_datamethod:normalize_datamethod inscripts/data_collector/baostock_5min/collector.pyprocesses data correctly without converting 'symbol' to float.normalize_baostockmethod to retain 'symbol' field as a string.Documentation update:
normalize_databefore usingdump_bin.pyinscripts/data_collector/baostock_5min/README.md.