Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript root enum requests still failing to build #4405

Closed
baywet opened this issue Mar 26, 2024 · 0 comments · Fixed by #4406
Closed

typescript root enum requests still failing to build #4405

baywet opened this issue Mar 26, 2024 · 0 comments · Fixed by #4406
Assignees
Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code
Milestone

Comments

@baywet
Copy link
Member

baywet commented Mar 26, 2024

follow up to #4199

beta build gets the following error Error: deviceManagement/chromeOSOnboardingSettings/connect/index.ts(89,9): error TS2322: Type 'string' is not assignable to type 'Record<string, unknown>'.

This matches the "enumObject" part of this section

export const ConnectRequestBuilderRequestsMetadata: RequestsMetadata = {
    post: {
        uriTemplate: ConnectRequestBuilderUriTemplate,
        responseBodyContentType: "application/json",
        errorMappings: {
            XXX: createODataErrorFromDiscriminatorValue as ParsableFactory<Parsable>,
        },
        adapterMethodName: "sendEnum",
        enumObject: "ChromeOSOnboardingStatus",
        requestBodyContentType: "application/json",
        requestBodySerializer: serializeConnectPostRequestBody,
        requestInformationContentSetMethod: "setContentFromParsable",
    },
};

I believe the generation should not emit the quotes around ChromeOSOnboardingStatus, but it remains to be investigated

@baywet baywet added type:bug A broken experience TypeScript Pull requests that update Javascript code labels Mar 26, 2024
@baywet baywet added this to the Kiota v1.13 milestone Mar 26, 2024
@baywet baywet added this to Kiota Mar 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in Kiota Mar 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kiota Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants