Backing store when using deserialize async

[svrooij]

I was trying to use the serialize / deserialize to save and load an object for the graph api.

The idea was this (graph or any other api):

1. Get an object from the API (or create a new object in C#)
2. Serialize it as json
3. (optional) change the json file
4. Deserialize the object from json
5. Post the object to a new tenant (or create the entry if it did not exist already)

In this last step I was faced with a 400 error, and after inspecting the request I figured out that none of the properties where sent to the server.

I think that users that actually use this static method or any of the extensions that call this method don't want the backing store.

And I would thus suggest that this method automatically sets the model.BackingStore.InitializationCompleted to false. That resulted in the full object being posted.

[baywet]

Hi @svrooij
Thank you for using kiota and for reaching out.

If I'm understanding you correctly, you effectively want to do the opposite of what you've already implemented for the serialization? i.e. have an optional boolean parameter to "set everything as changed" by default (default value false)

If so, is this something you'd like to submit a pull request for provided some guidance?

[svrooij]

@baywet I changed the initial description. (Was written on a tablet)

[baywet]

Thank you for the additional information.
I think we're on the same page.
Is this something you'd like to submit a pull request for provided some guidance?

[svrooij]

I'm willing to create a PR for this, but what do you suggest? Can I just change it to resetting the backing store if someone uses this method to deserialize? I guess it's not used by the other code, that will probably call the code directly without the KiotaSerializer.Deserialize(...)

• Just reset the backing store to see everything deserialized this way is seen as changed
• Make a parameter, which defaults to yes reset
• Make a parameter which defaults to the old behavior

[baywet]

for consistency I'd align with previous changes we've made: parameter named something like "markAllValuesAsChanged" default false. This way we don't change the current behaviour for people using the methods today. What do you think?

[svrooij]

How do I add an addition parameter to this method?

kiota-dotnet/src/abstractions/serialization/KiotaSerializer.Deserialization.cs

Lines 166 to 168 in 427e3ff

	public static async Task<T?> DeserializeAsync<T>(string contentType, string serializedRepresentation, ParsableFactory<T> parsableFactory,
	CancellationToken cancellationToken = default) where T : IParsable
	{

I heard that the CancellationToken should be the last parameter. If I add it in between, it will be source breaking.

Just add a new method? and an obsolete to the old?

[baywet]

Just add a new method? and an obsolete to the old?

I'm afraid that's the only option here

[svrooij]

Shall I add this to the same PR? #396

[baywet]

It'd probably be easier to have separate PRs at this point.