Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRequestAdapter should have sendEnum and sendEnumCollection methods #199

Open
andrueastman opened this issue Feb 21, 2024 · 2 comments
Open
Labels
area:abstractions Focused on functional module of the product area:http breaking-change enhancement New feature or request

Comments

@andrueastman
Copy link
Member

To align with other languages like go/java, IRequestAdapter should have sendEnum and sendEnumCollection methods to handle APIs that return enums.

At the moment this is mapped to sendPrimitive methods which does not align with other languages. This is a breaking change and should be resolved in the next major version of the lib.

@baywet
Copy link
Member

baywet commented Feb 21, 2024

Thanks for starting a discussion on this.
Since send primitive performs the work of both, what issue are you trying to resolve by adding specific methods?

@andrueastman
Copy link
Member Author

Hey @baywet,

From my perspective, this is more about consistency/alignment across languages which we can look into taking care of in the next breaking change of the library.
Furthermore, in the event someone is implementing their own version of IRequestAdapter it is unclear that they can handle enums in the primitive section. Updating the interface makes things clearer I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:abstractions Focused on functional module of the product area:http breaking-change enhancement New feature or request
Projects
Status: New📃
Development

No branches or pull requests

2 participants