-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip or honor ASCII color coding #1569
Comments
Yeah, this is on our backlog. labelling as an enhancement. |
Any update? As the maintainer of a build package which uses ANSI colours, I'm starting to get questions. |
we are fixing this step by step.
|
Thanks for the info. AFAIK the web UI still doesn't support ANSI colour codes, see https://dev.azure.com/blairconrad/SendComics/_build/results?buildId=9&view=logs&jobId=011e1ec8-6569-5e69-4f06-baf193d1351e&taskId=b8cbf579-6a08-5e02-2788-e25b5bd52b1b&lineStart=13&lineEnd=14&colStart=1&colEnd=1 @blairconrad you reported adamralph/bullseye#150 - are you still seeing this problem in the web UI? |
@adamralph, I see no change. ANSI codes show up in the web UI: https://dev.azure.com/blairconrad/SendComics/_build/results?buildId=13 |
The web UI supports minimal set of escape codes, but the full support is coming soon. But we understand the request and are working on it. |
Changes should be rolling out. We support ANSII color code now.
|
PRETTY! |
Not to be a Negative Nelly, but I notice that while the completed build output looks nice and colourful, the in-progress output does not deal well with the ANSI codes: (from the in-progress build of https://dev.azure.com/blairconrad/blair%20bullseye/_build/results?buildId=18) |
That's a known limitation now unfortunately, we don't use the same view for both views :( |
Oh, thanks for the speedy response. Glad it's known! |
I hate to complain, but as @adamralph noted over at adamralph/bullseye#199 (comment), in some cases the combination of the ANSI escape codes and You can see the HTML produced for the ANSI-less and ANSI-ful output here: <div style="top:192px;height:16px;" class="view-line">
<span><span class="mtk1">2018-12-14T19:46:38.8739531Z No colour</span></span>
</div>
<div style="top:208px;height:16px;" class="view-line">
<span><span class="mtk1">2018-12-14T19:46:38.8741003Z <options></span></span>
</div>
<div style="top:224px;height:16px;" class="view-line">
<span><span class="mtk1">2018-12-14T19:46:38.8758154Z </span></span>
</div>
<div style="top:240px;height:16px;" class="view-line">
<span><span class="mtk1">2018-12-14T19:46:38.8759918Z Yellow foreground</span></span>
</div>
<div style="top:256px;height:16px;" class="view-line">
<span><span class="mtk1"><span>2018-12-14T19:46:38.8761200Z </span>‌<span class="ansifg-y "><options></options></span>‌</span></span>
</div> It seems that once the ASNI codes are used, Is https://developercommunity.visualstudio.com/spaces/21/visual-studio-team-services.html?type=idea still the right place to mention this or is there a better place? |
Here are the known limitations with this feature -
This is something we decided to live with until we address all of them together in the next spike which is planned soon. We decided to go ahead with the feature even with those as it's much better than showing some random useless characters :) If you are curios on the limitations, we use monaco editor, which isn't really made for "viewing" experience. So to bring color coding support, we had to have those limitations for the interm... Thanks for reporting and we understand the issues you mentioned and we plan to work on those, let us know if you find anything else. For this particular issue, I think having it here makes sense as everything is being discussed here, but in general yes, dev community is the place to track these. |
Thanks for the response @yaananth. I had doubts about https://developercommunity.visualstudio.com/spaces/21/visual-studio-team-services.html?type=idea as the "idea" at the end sounds more like feature requests, not bug reports. I eagerly await the next release and appreciate all your efforts. And I realize that every client is different, but given the choice between "bonus funny characters in the output" and "some sections of the output just omitted altogether", I'd've picked the second. The recovery mode of the first is "just try not to look at the funny characters" while for the second it's "hopefully realize something is wrong and then pore over the source HTML". |
You can report a problem: https://developercommunity.visualstudio.com/content/problem/post.html?space=21 |
@yaananth earlier you said:
So you have knowingly introduced a bug. Why do you need someone to "report" it? |
@yaananth Is there an open issue to fix this limitation? I searched in the Visual Studio Community but couldn't find a related discussion. Copy-paste works for in-progress builds but it stops working when the colors have rendered after the build completes. To reproduce, try copy-pasting line 4000 from the |
Have there been any advances regarding the character encoding not being resolved? |
Multistage pipelines feature will bring new views which will honor ansii codes, evening when live streaming! |
We support https://en.wikipedia.org/wiki/ANSI_escape_code#3/4_bit Which we don't support yet. |
Debugging a Teraform pipeline has lead me here. Like others I can make the logging more readable with the -no-color switch but the lack of colour in the output still reduces the readability of what I'm looking at. It would be a huge help if this could be supported. |
Another chime in hope someone from MS responds to this in any way, including "this is backlog/icebox/what". |
Hi everyone, this issue does not seem to be related to the agent itself (since agent does not handle logs view, but only sends them to server) - for the Azure DevOps features/issue reports I would suggest to open a ticket on https://developercommunity.visualstudio.com/search?space=21 to get right eyes on it. |
For anyone following the thread: https://developercommunity.visualstudio.com/t/Colorful-logs-in-Release-Pipeline-as-wel/1652600 |
@jessehouwing why is this closed? I'm still seeing this issue, particularly on the "raw logs" view of Azure CI pipelines. |
This issue has had no activity in 180 days. Please comment if it is not actually stale |
This is still an issue unfortunately |
Hello, this is still a big issue, are we actively working on it? If you give me access to the internal Repo here in MS I can try to give a hand. Thanks. |
Energizer bunny... Still going..
|
Any progress on this? |
Bump, still very important feature missing. |
@FreddyAyala I understand you work for Microsoft, correct? Could you solve this internally, or talk to whatever team's responsible for this? |
Dear Azure team, any news on fixing this annoyance? or, do you really expect people to keep working around it with, for example: cat log.txt | sed -e $'s/\x1b\[[0-9;]*m//g' > log.clean.txt |
The feedback I've just received from Azure DevOps to my request posted at https://twitter.com/mloskot/status/1760636981028016191 seems to suggest that begging Azure for attention here is a waste of time: |
Looking forward to get this fixed |
Another one bumps the thread. Looking forward to be fixed |
+1 |
Agent Version and Platform
2.133.3
Windows | Linux
VSTS Type and Version
VisualStudio.com
If VisualStudio.com, what is your account name? http://psd30.visualstudio.com
What's not working?
When a commandline tool issues ASCII colour coding information (e.g.
�[?25l
) they are shown in the logs and make it harder to read.It would be useful to either honor the color coding, somehow instruct/configure the terminal as monochrome or stripping out the nonsense characters.
The text was updated successfully, but these errors were encountered: