Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--import-in-place does not invoke plugin WSLPluginAPI_OnDistributionRegistered #12370

Open
1 of 2 tasks
jxy-s opened this issue Dec 12, 2024 · 3 comments
Open
1 of 2 tasks
Assignees
Labels
bug emailed-logs Logs have been emailed

Comments

@jxy-s
Copy link

jxy-s commented Dec 12, 2024

Windows Version

Microsoft Windows [Version 10.0.22631.4460]

WSL Version

2.3.24.0

Are you using WSL 1 or WSL 2?

  • WSL 2
  • WSL 1

Kernel Version

5.15.153.1-2

Distro Version

No response

Other Software

No response

Repro Steps

  1. Run wsl --import-in-place Ubuntu C:\Users\User\Desktop\Ubuntu-24.04-LTS-x86_64.vhdx
    • Observe that WSLPluginAPI_OnDistributionRegistered is not invoked
  2. Check and observed that the distribution is in fact registered: wsl --list
  3. Run wsl --distribution Ubuntu (checking if the distribution registration callout is invoked later)
    • Observe that the WSLPluginAPI_OnDistributionRegistered is not invoked
    • Observe that WSLPluginAPI_OnDistributionStarted is invoked without any prior WSLPluginAPI_OnDistributionRegistered
  4. Run wsl --unregister Ubuntu
    • Observed that the OnDistributionUnregistered is invoked

In contrast, using --import invokes the distribution registered plugin callout immediately. This behavior means that using --import-in-place does not provide visibility of a distribution being registered to the plugin. The plugin is only informed of a distribution being unregistered when --import-in-place is used. Also note that --import invokes the plugin callout immediately, it does not require the distribution be started.

Expected Behavior

The --import-in-place command should result in WSLPluginAPI_OnDistributionRegistered being invoked just as --import does.

Actual Behavior

The --import-in-place command never notifies the plugin of distribution registration.

Diagnostic Logs

No response

Copy link

Logs are required for review from WSL team

If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'.
Otherwise please attach logs by following the instructions below, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.

How to collect WSL logs

Download and execute collect-wsl-logs.ps1 in an administrative powershell prompt:

Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/microsoft/WSL/master/diagnostics/collect-wsl-logs.ps1" -OutFile collect-wsl-logs.ps1
Set-ExecutionPolicy Bypass -Scope Process -Force
.\collect-wsl-logs.ps1

The script will output the path of the log file once done.

If this is a networking issue, please use collect-networking-logs.ps1, following the instructions here

Once completed please upload the output files to this Github issue.

Click here for more info on logging
If you choose to email these logs instead of attaching to the bug, please send them to [email protected] with the number of the github issue in the subject, and in the message a link to your comment in the github issue and reply with '/emailed-logs'.

View similar issues

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@jxy-s
Copy link
Author

jxy-s commented Dec 12, 2024

/emailed-logs

Copy link

Diagnostic information
Found '/emailed-logs', adding tag 'emailed-logs'

@github-actions github-actions bot added the emailed-logs Logs have been emailed label Dec 12, 2024
@OneBlue OneBlue added the bug label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug emailed-logs Logs have been emailed
Projects
None yet
Development

No branches or pull requests

3 participants