Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout Manual Theme Setting #23831

Open
BLM16 opened this issue Feb 3, 2023 · 4 comments · May be fixed by #24169
Open

Flyout Manual Theme Setting #23831

BLM16 opened this issue Feb 3, 2023 · 4 comments · May be fixed by #24169
Assignees
@BLM16
Labels
Area-Flyout Issues refering to the PowerToys flyout launched from the tray area Area-Runner The PowerToys main executable Area-User Interface things that regard UX for PowerToys Status-In progress This issue or work-item is under development

Comments

@BLM16
Copy link
Contributor

BLM16 commented Feb 3, 2023

Description of the new feature / enhancement

Currently the new flyout from v0.67.0 uses the windows default theme. It would be nice to have the ability to change this theme manually via the settings menu.

I have light mode set for my windows apps by default, however my "windows theme" is dark. As PT is intended to feel native to windows, being able to customize the theme so it uses dark mode to match my windows setting not my app setting would be nice.

image

It might even be worth making this the default theme for the flyout, using windows' theme over the app theme for the flyout only.

Scenario when this would be used?

The contrasting theme on the flyout which should feel native doesn't make PT feel like it is a part of windows.

Supporting information

No response
@BLM16 BLM16 added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 3, 2023
@BLM16 BLM16 linked a pull request Feb 17, 2023 that will close this issue
Open
9 tasks
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Feb 19, 2023 •
edited
Loading

Interesting. Does that mean you feel our fly-out is similar to the OS fly-outs? Note that the OneDrive (=app) fly-out and the Bluetooth menu (=OS) also follow the app theme. Even in Windows 11. The way you say it makes it feel like a personal opinion, but I suppose have the option can't harm :)
@niels9001 I believe you also had an opinion about the feeling of our fly-out...

@Jay-o-Way Jay-o-Way added Area-Runner The PowerToys main executable Area-User Interface things that regard UX for PowerToys labels Feb 19, 2023
@Jay-o-Way Jay-o-Way moved this to In Progress ⚒️ in Test for PowerToys Feb 19, 2023
@niels9001
Copy link
Contributor

I'd say the flyout should use the taskbar theme.. (like Notification Center and Quick Actions). But I wonder how we could catch that in a window itself.

@BLM16
Copy link
Contributor Author

BLM16 commented Feb 19, 2023

I mentioned a few things in the PR, and adding the option was quite easy. I need to fix the window and make the theme update apply without restarting PT.

The question is what the default theme option should be. Do we want to match the PT theme? Match the default app theme? Match the OS theme?

I think all should be options, but the default should be decided upon.

@Jay-o-Way
Copy link
Collaborator

Good question. This would be a good candidate for a Discussions poll.

@Jay-o-Way Jay-o-Way added the Area-Flyout Issues refering to the PowerToys flyout launched from the tray area label Mar 17, 2023
@crutkas crutkas added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams In progress labels May 10, 2023
@davidegiacometti davidegiacometti mentioned this issue Apr 11, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLM16 BLM16

Labels
Area-Flyout Issues refering to the PowerToys flyout launched from the tray area Area-Runner The PowerToys main executable Area-User Interface things that regard UX for PowerToys Status-In progress This issue or work-item is under development
Projects
Test for PowerToys
Status: In Progress ⚒️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added flyout theme setting BLM16/PowerToys
4 participants
@crutkas @niels9001 @BLM16 @Jay-o-Way