Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Idea]: OAuth2 Authorization Code Flow with PKCE #787

Open
1 task done
diogoviegas2855 opened this issue Mar 19, 2024 · 5 comments
Open
1 task done

[BC Idea]: OAuth2 Authorization Code Flow with PKCE #787

diogoviegas2855 opened this issue Mar 19, 2024 · 5 comments
Assignees
Labels
AL: System Application Approved The issue is approved BCIdea Issue related to a BCIdea Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Comments

@diogoviegas2855
Copy link

diogoviegas2855 commented Mar 19, 2024

BC Idea Link

https://experience.dynamics.com/ideas/idea/?ideaid=c432a449-f9e5-ee11-a73d-6045bdb71da1

Description

Provide support for Authorization Code Flow with PKCE by adding overloads or procedures to codeunit 501 OAuth2 and codeunit 502 OAuth2Impl.

If an external party requires Authorization Code Flow with PKCE there is no method that allows to add additional query parmeters to the authorization URL.

The intention of this issue is to add overloads or procedures to provide functionality to allow the OAuth2 flow with code_verifier and code_challenge parameters.

I will provide the implementation for this BC Idea

  • I will provide the implementation for this BC Idea
    Internal work item: AB#521506
@mazhelez mazhelez added the BCIdea Issue related to a BCIdea label Mar 21, 2024
@bcbuild-github-agent bcbuild-github-agent added the Linked Issue is linked to a Azure Boards work item label Mar 26, 2024
@mickcarr
Copy link

Just encountered this with a client where they require support for conditional access authentication context (claims, acrs). I see this is approved back in March. Is anyone aware if this has been actioned I see that there's an internal work item that has been created for this?

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 16, 2024
@JesperSchulz
Copy link
Contributor

This issue hasn't been picked up yet. @diogoviegas2855 suggested to provide a fix, but I haven't come across one yet 😊

@diogoviegas2855
Copy link
Author

diogoviegas2855 commented Sep 27, 2024

I haven't had the time to provide a fix, i will try to do it in the future, but if anyone wanna provide one first :)

@ajkauffmann
Copy link
Contributor

Happy to pick up this one if you don't mind.

@JesperSchulz
Copy link
Contributor

Happy to pick up this one if you don't mind.

It's all yours, my friend 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application Approved The issue is approved BCIdea Issue related to a BCIdea Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

No branches or pull requests

6 participants