Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Subsites to be parents not just Services #259

Open
dedavidson opened this issue May 22, 2024 · 5 comments
Open

Allow Subsites to be parents not just Services #259

dedavidson opened this issue May 22, 2024 · 5 comments

Comments

@dedavidson
Copy link

Currently all the content types such as Directories, Guides etc have a parent field localgov_services_parentwhich only references Services. This uses a plugin implementation in modules/localgov_services_navigation/src/Plugin/EntityReferenceSelection/ServicesSelection.php which is why I have opened the issue here.

Similar to #211 the use case is when a Subsite needs to include service pages, Directories or Guides.

Correcting this properly in my mind would require changes to all the modules that provide parent linkage so that it doesn't refer to just Services. That is a large task so a more pragmatic approach might be just to change the plugin implementation to allow both the localgov_subsites_overview and localgov_guides_overview bundles. Individual sites can then enable them if they wish to allow parentage other than just Services.

@willguv
Copy link
Member

willguv commented May 22, 2024

Thanks @dedavidson

How are the relationships made between subsite overviews and other page types in the H&F set up please @justinepocock @rupertj ?

@rupertj
Copy link
Member

rupertj commented May 22, 2024

@willguv Depends which relationships you mean. Do you mean including them in the subsite, or something else?

If that is what you mean, it's all determined by the menu. There's special handling for directories to let directory pages in if you put their directory channel under a subsite homepage in the menu. I've opened an issue on subsites_extras to allow that to be extended for guides and other page types that have the same page/overview page structure. (Although the H&F web team worked around that by putting every guide page in the menu.... Not ideal, but it did work!)

@dedavidson
Copy link
Author

dedavidson commented May 22, 2024

@rupertj will that change the breadcrumb for the directory so that it "feels" part of the subsite?

@rupertj
Copy link
Member

rupertj commented May 22, 2024

It doesn't do anything with the breadcrumbs. They just worked anyway from what I've seen.

For example, here's one of H&F's directories in a subsite: https://www.lbhf.gov.uk/children-and-young-people/family-hub/find-family-hub-or-childrens-centre

@willguv
Copy link
Member

willguv commented May 22, 2024

Hi @rupertj I meant including them in the subsite. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants