Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search/facets don't appear on search results #41

Open
danchamp opened this issue Jul 13, 2021 · 8 comments
Open

Search/facets don't appear on search results #41

danchamp opened this issue Jul 13, 2021 · 8 comments
Assignees

Comments

@danchamp
Copy link
Collaborator

danchamp commented Jul 13, 2021

Follow-up to: localgovdrupal/localgov_base#80

This is inconsistent with events and directories, where search and facets remain visible and populated on search results pages.

@markconroy markconroy removed their assignment Jul 14, 2021
@markconroy
Copy link
Member

Unassigning myself from this. I'll do the frontend/template/CSS work if it's needed.

@finnlewis
Copy link
Member

Just to add detail to this, from : localgovdrupal/localgov_base#80

A couple of questions:

1. Can we include the search form on the search page, as we do with events and directories? (This may be a module issue.)
2. Can we make it easier to switch the sidebar to the right side? 
     At present I need to over-ride the whole template. Alternatively, we could default to having the sidebar on the right side, 
     matching the pattern at BHCC, London Councils, and Croydon?

@finnlewis
Copy link
Member

So I think we want this:

  • On a default install of localgov_news
  • On the /news/* search results pages
  • Add the exposed search block to the sidebar first
  • Add the facet blocks for category and date.

So it looks something like this:

image

@finnlewis
Copy link
Member

@danchamp have you already done some work on this?

@finnlewis
Copy link
Member

I've added some optional config which kicks in if the localgov_base theme is already enabled.

It is an odd situation, when enabling the localgov_news with the localgov_theme enabled, it seems to pick up the block config sometimes or in some situations, but not always.

When enabling the localgov_base theme first, then enabling the localgov_news module, it is clear that we need the specific config available to place the blocks.

What do you think @danchamp ?

@rupertj
Copy link
Member

rupertj commented Apr 26, 2024

This looks like another issue that can be fixed by localgovdrupal/localgov_core#211

@msayoung
Copy link
Member

Is it possible this has now been fixed @finnlewis ?

@ekes
Copy link
Member

ekes commented Oct 22, 2024

I'm guessing it's better/fixed for the OP; but can be even better fixed by Rupert's new block placement system. So maybe we keep this history and repurpose the ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants