Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Consider supporting mimesis as a fake data provider #394

Open
sobolevn opened this issue Sep 27, 2023 · 6 comments
Open

Enhancement: Consider supporting mimesis as a fake data provider #394

sobolevn opened this issue Sep 27, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@sobolevn
Copy link
Member

sobolevn commented Sep 27, 2023

Summary

faker is great! But, https://github.com/lk-geimfari/mimesis is also very cool. It is faster and has way more types of data and data itself.

It would be very nice to include the support for it, since it can add more structured data to users' structures.

I happen to be a maintainer of both :)

CC @lk-geimfari

Basic Example

No response

Drawbacks and Impact

It can increase the comlexity of the project.

Unresolved questions

No response


Funding

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@sobolevn sobolevn added the enhancement New feature or request label Sep 27, 2023
@guacs
Copy link
Member

guacs commented Sep 27, 2023

Should we add support for it or just completely switch out faker with mimesis? I think the latter would be easier (albeit a breaking change), and also don't see too much benefit in supporting both of them.

@litestar-org/members, thoughts?

@provinzkraut
Copy link
Member

Should we add support for it or just completely switch out faker with mimesis? I think the latter would be easier (albeit a breaking change), and also don't see too much benefit in supporting both of them.

@litestar-org/members, thoughts?

+1 for switching to mimesis if it proves to be beneficial in terms of ergonomics and/or performance.

@v3ss0n
Copy link

v3ss0n commented Sep 27, 2023

just checked and that whats i am actually looking! cool!.

@cofin cofin changed the title Consider supporting mimesis as a fake data provider Enhancement: Consider supporting mimesis as a fake data provider Sep 27, 2023
@lk-geimfari
Copy link

I would be happy to provide assistance with the transition to mimesis. Let me know if you have any questions.

@kaine-bruce-dmt
Copy link

kaine-bruce-dmt commented Jun 24, 2024

New to the project. Was looking into Polyfactory (as TypedDict/dataclass/Pydantic support)

In general I have started using Mimesis over Faker.

I have definitely felt the benefits of Mimesis over Faker in terms of performance. Mainly spin up time on generating X amount of test data for unit tests.

Was anything ever done with this? Is the project still using Faker under the hood?

@guacs
Copy link
Member

guacs commented Jun 24, 2024

@kaine-bruce-dmt Hey, thanks for the interest! This is something that's planned, however it'd be nice if we could do it in a way that we can allow users to use faker or mimesis. Basically, create an abstraction layer that has a defined interface so that any such data generation library (or a custom implementation) could be used. So, currently this is still using faker under the hood.

This may be a breaking change, but I think that's okay and worth doing. It might be possible to do this in a non-breaking way, but I'm not too sure about that. I've been meaning to implement this, but I haven't had the time the past few months to work on it.

If you have any ideas or questions, please feel free to ask. We'd be happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants