Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for all platforms #7

Open
5 of 9 tasks
Youw opened this issue May 6, 2023 · 7 comments
Open
5 of 9 tasks

Add CI for all platforms #7

Youw opened this issue May 6, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Youw
Copy link
Member

Youw commented May 6, 2023

Any other platforms?

@mcuee mcuee added the enhancement New feature or request label May 7, 2023
@mcuee
Copy link
Member

mcuee commented May 7, 2023

I changed FreeBSD to NetBSD as FreeBSD has their own version of libusb under BSD licenses and it is part of the FreeBSD system (not an add-on).

@mcuee
Copy link
Member

mcuee commented May 7, 2023

There are other platforms like Solaris and Haiku but I guess we may not want to deal with them.

Reference:

@mcuee
Copy link
Member

mcuee commented May 7, 2023

@Youw

I have no ideas about WebAssembly + WebUSB support.
https://github.com/libusb/libusb/wiki#supported-environments

@mcuee
Copy link
Member

mcuee commented May 7, 2023

@Youw

For the CI action, it will be good to keep the binaries as well, at least for Windows (MSVC x86/x64/ARM/ARM64 and MinGW x86/x64).

@Youw
Copy link
Member Author

Youw commented May 7, 2023

There are other platforms like Solaris and Haiku but I guess we may not want to deal with them.

My thoughs: right now it is not a part of CMake implementation. As soon as someone needs those (and adds its support to CMakeLists.txt) - we will think about a CI for it too.

@Youw
Copy link
Member Author

Youw commented May 7, 2023

good to keep the binaries as well

I'm not so sure about that. Not any time soon.
Firstly - because CMake is not an official build system for libusb.
Secondly - the main purpose of this repo is to be able to build libusb with CMake.

If someone needs a prebuilt binaries - that better be provided by a mainline libusb repo/be a part of its release process/etc.


Sure, it will be useful for some, e.g. temporary binaries saved as part of a PR (e.g. to verify a bugfix for someone or so).
But I don't want people to expect to find prebuilt binaries here. And even the bugfix verification - that's more about PRs to libusb itself, not to libusb-cmake.

@mcuee
Copy link
Member

mcuee commented May 7, 2023

@Youw

I agree with you now, not to keep the binary as this is not official libusb. Rather we should improve libusb github action to keep Windows binaries, not in libusb-cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants