Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the table header #6123

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Fix the table header #6123

wants to merge 11 commits into from
+13 −1

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Dec 13, 2024 •
edited
Loading

Description

I fixed the table header and made sure it sticks to the top when the user scrolls down to the bottom of the table.

Sticky-Fix.mp4

This PR fixes #6122

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Ajay-singh1
Fix the table header
f45d294 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 13, 2024

🚀 Preview for commit f45d294 at: https://675bac17372c735eceae643a--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 13, 2024 03:42
@l5io
Copy link
Contributor

l5io commented Dec 13, 2024

🚀 Preview for commit f7cb1cf at: https://675bb7d8dadd4f745574215e--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit bc5e0bb at: https://675e584a2595e40773fc04b5--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit 4bb27eb at: https://675ea82231599248107b5504--layer5.netlify.app

@Ajay-singh1
Set the scrollable area
af39f2d 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit af39f2d at: https://675eb282240fcb67686b84a4--layer5.netlify.app

@Ajay-singh1
Make the view area large
ebca5a7 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit ebca5a7 at: https://675ebb942f2ee47477aec024--layer5.netlify.app

@Ajay-singh1
Make the view area larger
2cdb831 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit 2cdb831 at: https://675ebff45b4ce967721eee44--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 15, 2024

🚀 Preview for commit 944c70b at: https://675ec5adfda1837410d0c746--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as ready for review December 15, 2024 12:46
@vishalvivekm
Copy link
Member

@Ajay-singh1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Dec 18, 2024

🚀 Preview for commit a7e1ce3 at: https://6762cc0d67c92100c0296986--layer5.netlify.app

@Ajay-singh1
Update comparison.js
3c94054 
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 18, 2024

🚀 Preview for commit 3c94054 at: https://6762d30b3cf02a047a0fd5e1--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 18, 2024

🚀 Preview for commit 882f184 at: https://6762dfcd4e295526e1537d42--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pricing] Make Tier Comparison Header Sticky
3 participants
@Ajay-singh1 @l5io @vishalvivekm