Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/exclude metrics buckets #49

Open
gilliardmacedo opened this issue May 13, 2021 · 2 comments
Open

Disable/exclude metrics buckets #49

gilliardmacedo opened this issue May 13, 2021 · 2 comments

Comments

@gilliardmacedo
Copy link
Member

From labbsr0x/servlet-monitor#31

Only more advanced users of Prometheus metrics really uses buckets/histograms. By removing metrics buckets, we will reduce in over 60% the amount of processing and byte output in our metrics endpoint with no loss in quality.

Currently we have something like this for each metrics/label combination:

request_seconds_bucket 1
request_seconds_bucket 2
request_seconds_bucket 3
request_seconds_bucket 4
request_seconds_bucket +inf
request_seconds_sum
request_seconds_count
response_size_bytes

By removing buckets, we would reduce to something like

request_seconds_sum
request_seconds_count
response_size_bytes

Proposal

  • Buckets metrics made optional for request_seconds and dependency_request_seconds
  • Disable buckets output by default (will only generate _sum and _count metrics for each request)
  • Only enable buckets if configured explicitly using existing param "buckets" with values like "0.1,0.3,2,10" for example
@flaviostutz
Copy link
Member

flaviostutz commented May 13, 2021 via email

@eabili0
Copy link
Contributor

eabili0 commented Jul 21, 2021

@flaviostutz @gilliardmacedo makes sense to me. Sorry for such a late response (not really having time to open source as of now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants