Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/k8s #38

Merged
merged 22 commits into from
Jun 15, 2020
Merged

Feature/k8s #38

merged 22 commits into from
Jun 15, 2020

Conversation

KarineValenca
Copy link
Collaborator

solves #23

@KarineValenca KarineValenca requested a review from eabili0 June 3, 2020 14:03
@eabili0
Copy link
Contributor

eabili0 commented Jun 3, 2020

@KarineValenca, please add a README.md to the k8s folder as documentation explaining how to use the provided files and what values might need to be replaced before execution (e.g. TELEGRAM_TOKEN).

Also, please add a referente do this k8s documentation on the the main README.md file.

Thank you!

@KarineValenca
Copy link
Collaborator Author

@abilioesteves Could you review it again? I added the README.md file, and also did some changes in the k8s files.

@eabili0
Copy link
Contributor

eabili0 commented Jun 15, 2020

@KarineValenca, it all seems good. This PR made me think that the examples we have only cover the "Federation" capabilities of Big Brother. It does not cover the HA (High Availability) capabilities with Cortex.

I'll open two issues from this observations:

  1. Big Brother's readme should explicitly tell that Big Brother comes in two "flavors":
  • Federated
  • Cortex
  1. We should also have a Big Brother example for the HA capability.

@eabili0 eabili0 merged commit 5746157 into master Jun 15, 2020
@eabili0 eabili0 deleted the feature/k8s branch June 15, 2020 13:16
@eabili0 eabili0 linked an issue Jun 15, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Big Brother come in two flavors?
2 participants