Regression caused by #1826

[ghost]

The PR #1826 caused a regression in our Compose file:

services:
  a:
    image: alpine:3.19
    command: ["cat", "/etc/hello_world.yaml"]
    secrets:
      - source: hello-world
        target: /etc/hello_world.yaml
secrets:
  hello-world:
    file: config/hello_world.yaml

Now, I am unable to cat /etc/hello_world.yaml, even though the names of the secret files match in the Compose file.

I would implement this solution differently, without touching any environments:

1. If target is specified, only ever transform the source field.
2. If target is not specified, fill it in as /run/secrets/{source_before_transform}.

The output of the original Compose by @sosan should be:

    spec:
      containers:
        - env:
            - name: MARIADB_ROOT_PASSWORD_FILE
              value: /run/secrets/MARIADB_PASSWORD
          image: mariadb:11
          name: database
          volumeMounts:
            - mountPath: /run/secrets
              name: mariadb-password
              subPath: MARIADB_PASSWORD
      restartPolicy: Always
      volumes:
        - name: mariadb-password
          secret:
            items:
              - key: mariadb-password
                path: MARIADB_PASSWORD
            secretName: mariadb-password

[cdrage]

@sosan

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[jvitor83]

I agree. We need to do as this issue author said:

• Without touching any environments
• If target is specified, only ever transform the source field.
• If target is not specified, fill it in as /run/secrets/{source_before_transform}.

I got a regression in my composes as well.

[cdrage]

/remove-lifecycle rotten

[cdrage]

@sosan @TessaIO