Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit-followup: consider dropping the iam.serviceAccountLister role #1753

Open
spiffxp opened this issue Mar 3, 2021 · 12 comments
Open

audit-followup: consider dropping the iam.serviceAccountLister role #1753

spiffxp opened this issue Mar 3, 2021 · 12 comments
Assignees
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@spiffxp
Copy link
Member

spiffxp commented Mar 3, 2021

context : #1737 (comment)

It's not super clear to me what its purpose is. The relevant service accounts or other roles may have subsumed the need for this?

/wg k8s-infra
/sig testing
/area access
/area cluster-mgmt
/priority backlog

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 3, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 1, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 2, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

OK so what are we dealing with here...

Grants permission iam.serviceAccounts.list for [email protected] on:

  • k8s-infra-prow-build
  • k8s-infra-prow-build-trusted
  • kubernetes-public

For all three projects, this group is also granted:

  • roles/compute.viewer
  • roles/container.admin

For kubernetes-public, this group is additionally granted:

  • roles/compute.loadBalancerAdmin
  • roles/stackdriver.accounts.editor
  • roles/stackdriver.accounts.viewer

Questions to answer:

  • does this permission come in from any other the other roles?
  • is this permission needed? why? (hazy recollection of gke/google group integration, but maybe making this up)

@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

Does this permission come in from any other the other roles?

$ for r in compute.viewer container.admin; do gcloud iam roles describe roles/$r | grep iam; done
$

No

@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

Hm. Usually, I use my personal account to try out less-privileged access stuff, but it happens to have read-only access to everything as an auditor, so it's not the best option here for repo'ing whether the permission is necessary.

@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed wg/k8s-infra labels Sep 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Oct 1, 2021

/remove-sig testing

@k8s-ci-robot k8s-ci-robot removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 1, 2021
@ameukam
Copy link
Member

ameukam commented Dec 14, 2021

/milestone v1.24

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.23, v1.24 Dec 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@ameukam
Copy link
Member

ameukam commented Mar 15, 2022

/remove-lifecycle stale
/lifecycle frozen
/milestone clear

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 15, 2022
@riaankleinhans riaankleinhans moved this to Reporting, Audit & Logging in registry.k8s.io (SIG K8S Infra) Jan 4, 2023
@ameukam ameukam moved this to Backlog in SIG K8S Infra Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
Status: Backlog
Development

No branches or pull requests

5 participants