Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop advertising staging images, use registry.k8s.io or similar #113

Open
BenTheElder opened this issue Apr 17, 2024 · 7 comments
Open

Stop advertising staging images, use registry.k8s.io or similar #113

BenTheElder opened this issue Apr 17, 2024 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@BenTheElder
Copy link
Member

As discussed previously in kubernetes/test-infra#31728 (comment)

A) GCR is deprecated
B) Serving from a single region registry like this is not cost efficient. Originally it was only internal consumption by the project's own CI deployment.

If we want to publish images for external users it should really be at https://registry.k8s.io/ (note: images must go through image promotion, you cannot direct push), for internal usage it could be moved to an AR.

Prow at minimum will have to go through kubernetes/k8s.io#1343 but will be special because other affected projects (at least as far as we know) serve users through registry.k8s.io already so the migration is less pressing ...

Really, we should be promoting images, along with tagging releases, now that we have a repo dedicated to prow.

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 17, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2024
@BenTheElder
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2024
@BenTheElder BenTheElder changed the title Stop advertising GCR images, use registry.k8s.io or similar Stop advertising staging images, use registry.k8s.io or similar Sep 25, 2024
@BenTheElder
Copy link
Member Author

cc @petr-muller @krzyzacy @upodroid

Staging registries are not intended for public consumption.
Can we start advertising images on registry.k8s.io instead?

https://github.com/kubernetes/k8s.io/tree/main/registry.k8s.io#managing-kubernetes-container-registries

@krzyzacy
Copy link
Contributor

do we need to do anything to publish images to registry.k8s.io or this is mostly doc updates + move the starter config?

@upodroid
Copy link
Member

We need to start releasing prow like we release all other Kubernetes projects. We then promote those images to registry.k8s.io

@krzyzacy
Copy link
Contributor

cc @AishSundar @chemikadze this will be a good starter task if you want to start ramping up somebody ^^

howardjohn added a commit to howardjohn/test-infra that referenced this issue Oct 30, 2024
Until kubernetes-sigs/prow#113 or somethign
similar is resolved we are in a weird state. For now just manually
update things...
@BenTheElder
Copy link
Member Author

do we need to do anything to publish images to registry.k8s.io or this is mostly doc updates + move the starter config?

I would suggest starting to tag actual versions, but just the date sha is technically enough.

Note that published tags are immutable and you can't yank the published date-sha, which will appear to have really high version numbers versus if you started publishing semver tags.

Otherwise:

  • promote the images (https://registry.k8s.io has docs/pointers for this)
  • switch docs / configs to point to the promoted images

istio-testing pushed a commit to istio/test-infra that referenced this issue Oct 30, 2024
Until kubernetes-sigs/prow#113 or somethign
similar is resolved we are in a weird state. For now just manually
update things...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants