Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved readiness probe for nfd-worker #1806

Open
marquiz opened this issue Jul 23, 2024 · 4 comments · May be fixed by #1838
Open

Improved readiness probe for nfd-worker #1806

marquiz opened this issue Jul 23, 2024 · 4 comments · May be fixed by #1838
Assignees
@omerap12
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Jul 23, 2024

What would you like to be added:

Improve the gRPC health server so that it doesn't report ready/live until the feature discovery has succeeded and the NodeFeature CR object has been created/updated.

Why is this needed:

Better reflect the actual readiness nfd-worker.
@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 23, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jul 23, 2024

ping @omerap12 😊

@omerap12
Copy link
Member

yeap :)
/assign

@marquiz marquiz mentioned this issue Jul 31, 2024
Draft
@omerap12 omerap12 linked a pull request Aug 17, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@TessaIO
Copy link
Member

TessaIO commented Oct 21, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nfd-worker: Add a readiness probe omerap12/node-feature-discovery
5 participants
@marquiz @k8s-ci-robot @k8s-triage-robot @omerap12 @TessaIO