Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameters to kueue-viz backend (listen-port, logs, verbosity, etc...) #3880

Open
1 of 3 tasks
akram opened this issue Dec 18, 2024 · 5 comments
Open
1 of 3 tasks
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@akram
Copy link
Contributor

akram commented Dec 18, 2024

What would you like to be added:
Add configuration parameters to kueue-viz backend (listen-port, logs, verbosity, etc...)

Why is this needed:
In the evenutality of grouping frontend and backend containers into the same pod, listen ports should be parametrizable.
Currently they are hardcoded both for frontend and backend to 8080; making it impossible to have frontend and backend in the same pod.

Completion requirements:
Have a parameter --listen=0.0.0.0:8181 to the backend and other startup parameters.

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@akram akram added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 18, 2024
@akram
Copy link
Contributor Author

akram commented Dec 18, 2024

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@akram:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 18, 2024
@SD-13
Copy link

SD-13 commented Dec 18, 2024

Hey @akram, I am new to this project and want to work on this issue.

I have a few doubts -
what would be the default backend port? 8181?
where else we need to update to use parameter values?

@vihaan-that
Copy link

vihaan-that commented Dec 18, 2024

Dear @akram I would like to know if the issue is still up, as I want to take my chance at solving it.

Thank you

@akram
Copy link
Contributor Author

akram commented Dec 18, 2024

Hey @akram, I am new to this project and want to work on this issue.

I have a few doubts - what would be the default backend port? 8181? where else we need to update to use parameter values?

hi @SD-13 ,

initially the default port was 8080 . You can keep this value as default or use 8181 . The thing is that, in the future we may have kueue-viz-frontend and kueue-viz-backend live in the same pod, so they must use different ports. frontend already uses 8080 as a default port. So, use 8181 by default for backend would allow to have no configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants