Only download kubeadm images where needed #10899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting multiples facts, we directly create the dict we need from kubeadm output.
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/M
mzaian
approved these changes
Feb 8, 2024
k8s-ci-robot
added
the
approved
MrFreezeex
approved these changes
Feb 8, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this merge broke the scale.yaml. Can you review it @VannTen? |
|
this merge broke the scale.yaml.
Meaning ? Can you open an issue for that ?
|
Same as @kevin-emodo said. |
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Apr 22, 2024
)" This reverts commit 4b0a134. The mentionned PR break scale.yml. This goes back to the status quo until a proper fix can be provided, at which point we'll reapply the PR.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 29, 2024
dibi-codes
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
* Refactor of kubeadm images listing Instead of setting multiples facts, we directly create the dict we need from kubeadm output. * Remove useless 'default' filters in roles/download * Only download kubeadm images where needed
dibi-codes
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
)" (kubernetes-sigs#11105) This reverts commit 4b0a134. The mentionned PR break scale.yml. This goes back to the status quo until a proper fix can be provided, at which point we'll reapply the PR.
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
* Refactor of kubeadm images listing Instead of setting multiples facts, we directly create the dict we need from kubeadm output. * Remove useless 'default' filters in roles/download * Only download kubeadm images where needed
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
)" (kubernetes-sigs#11105) This reverts commit 4b0a134. The mentionned PR break scale.yml. This goes back to the status quo until a proper fix can be provided, at which point we'll reapply the PR.
Rickkwa
pushed a commit
to Rickkwa/kubespray
that referenced
this pull request
Jun 26, 2024
)" (kubernetes-sigs#11105) This reverts commit 4b0a134. The mentionned PR break scale.yml. This goes back to the status quo until a proper fix can be provided, at which point we'll reapply the PR.
davidumea
pushed a commit
to elastisys/kubespray
that referenced
this pull request
Oct 25, 2024
)" (kubernetes-sigs#11105) This reverts commit 4b0a134. The mentionned PR break scale.yml. This goes back to the status quo until a proper fix can be provided, at which point we'll reapply the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
default)k8s_clusternodes, which should save some time, particularly on big clusters.Which issue(s) this PR fixes:
Fixes #9094
Special notes for your reviewer:
Does this PR introduce a user-facing change?: