fallback_ips: Gather facts from reachable hosts only #11006

Rickkwa · 2024-03-13T00:49:13Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

When working with a large fleet of nodes, there is inevitably going to be some unreachable nodes. The linked issue describes that when kubespray-defaults runs and there exists an unreachable node, then it causes the play to unexpectedly exit early.

This is a fix to fallback_ips.yml to let it finish the rest of the role when unreachable node(s) exist.

Which issue(s) this PR fixes:

Fixes #10993

Special notes for your reviewer:

Local setup (inventory and test playbook):

details

Inventory

[k8s_cluster:children]
kube_control_plane
kube_node
calico_rr

[kube_control_plane]
k8s1.local

[etcd]
k8s1.local

[kube_node]
k8s3.local  # unreachable
k8s2.local

[calico_rr]

Playbook

---
- name: Prepare nodes for upgrade
  hosts: k8s_cluster:etcd:calico_rr
  gather_facts: False
  any_errors_fatal: "{{ any_errors_fatal | default(true) }}"
  environment: "{{ proxy_disable_env }}"
  roles:
    - { role: kubespray-defaults }

  post_tasks:
    - name: Task that runs after
      debug:
        var: fallback_ips

Showing the original output before applying my PR:

details

PLAY [Prepare nodes for upgrade] ********************************************************************************************************************************************************************************

TASK [kubespray-defaults : Gather ansible_default_ipv4 from all hosts] ******************************************************************************************************************************************
ok: [k8s1.local] => (item=k8s1.local)
[WARNING]: Unhandled error in Python interpreter discovery for host k8s1.local: Failed to connect to the host via ssh: ssh: connect to host k8s3.local port 22: Connection timed out
failed: [k8s1.local -> k8s3.local] (item=k8s3.local) => {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}
ok: [k8s1.local -> k8s2.local] => (item=k8s2.local)
fatal: [k8s1.local -> {{ item }}]: UNREACHABLE! => {"changed": false, "msg": "All items completed", "results": [{"ansible_facts": {"ansible_default_ipv4": {"address": "10.88.111.29", "alias": "eth0", "broadcast": "10.88.111.255", "gateway": "10.88.111.254", "interface": "eth0", "macaddress": "bc:24:11:41:88:12", "mtu": 1500, "netmask": "255.255.252.0", "network": "10.88.108.0", "prefix": "22", "type": "ether"}, "discovered_interpreter_python": "/usr/bin/python3"}, "ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"fact_path": "/etc/ansible/facts.d", "filter": ["ansible_default_ipv4"], "gather_subset": ["!all", "network"], "gather_timeout": 10}}, "item": "k8s1.local"}, {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}, {"ansible_facts": {"ansible_default_ipv4": {"address": "10.88.111.30", "alias": "eth0", "broadcast": "10.88.111.255", "gateway": "10.88.111.254", "interface": "eth0", "macaddress": "bc:24:11:be:42:a6", "mtu": 1500, "netmask": "255.255.252.0", "network": "10.88.108.0", "prefix": "22", "type": "ether"}, "discovered_interpreter_python": "/usr/bin/python3"}, "ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"fact_path": "/etc/ansible/facts.d", "filter": ["ansible_default_ipv4"], "gather_subset": ["!all", "network"], "gather_timeout": 10}}, "item": "k8s2.local"}]}
...ignoring

NO MORE HOSTS LEFT **********************************************************************************************************************************************************************************************

PLAY RECAP ******************************************************************************************************************************************************************************************************
k8s1.local                 : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=1

After my PR:

details

PLAY [Prepare nodes for upgrade] ********************************************************************************************************************************************************************************

TASK [kubespray-defaults : Determine reachable hosts] ***********************************************************************************************************************************************************
ok: [k8s1.local] => (item=k8s1.local)
[WARNING]: Unhandled error in Python interpreter discovery for host k8s1.local: Failed to connect to the host via ssh: ssh: connect to host k8s3.local port 22: Connection timed out
failed: [k8s1.local -> k8s3.local] (item=k8s3.local) => {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}
ok: [k8s1.local -> k8s2.local] => (item=k8s2.local)
fatal: [k8s1.local -> {{ item }}]: UNREACHABLE! => {"changed": false, "msg": "All items completed", "results": [{"ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"data": "pong"}}, "item": "k8s1.local", "ping": "pong"}, {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}, {"ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"data": "pong"}}, "item": "k8s2.local", "ping": "pong"}]}
...ignoring

TASK [kubespray-defaults : Gather ansible_default_ipv4 from reachable hosts] ************************************************************************************************************************************
ok: [k8s1.local] => (item=k8s1.local)
ok: [k8s1.local -> k8s2.local] => (item=k8s2.local)

TASK [kubespray-defaults : Create fallback_ips_base] ************************************************************************************************************************************************************
ok: [k8s1.local -> localhost]

TASK [kubespray-defaults : Set fallback_ips] ********************************************************************************************************************************************************************
ok: [k8s1.local]
ok: [k8s2.local]
ok: [k8s3.local]

TASK [Task that runs after] *************************************************************************************************************************************************************************************
ok: [k8s1.local] => {
    "fallback_ips": {
        "k8s1.local": "10.88.111.29",
        "k8s2.local": "10.88.111.30",
        "k8s3.local": "127.0.0.1"
    }
}
ok: [k8s3.local] => {
    "fallback_ips": {
        "k8s1.local": "10.88.111.29",
        "k8s2.local": "10.88.111.30",
        "k8s3.local": "127.0.0.1"
    }
}
ok: [k8s2.local] => {
    "fallback_ips": {
        "k8s1.local": "10.88.111.29",
        "k8s2.local": "10.88.111.30",
        "k8s3.local": "127.0.0.1"
    }
}

PLAY RECAP ******************************************************************************************************************************************************************************************************
k8s1.local                 : ok=5    changed=0    unreachable=0    failed=0    skipped=3    rescued=0    ignored=1
k8s2.local                 : ok=2    changed=0    unreachable=0    failed=0    skipped=2    rescued=0    ignored=0
k8s3.local                 : ok=2    changed=0    unreachable=0    failed=0    skipped=2    rescued=0    ignored=0

Also to note, I originally tried making this change to add ignore_errors: true:

details

# roles/kubespray-defaults/tasks/fallback_ips.yml
 ---
 # Set 127.0.0.1 as fallback IP if we do not have host facts for host
 # ansible_default_ipv4 isn't what you think.
 # Thanks https://medium.com/opsops/ansible-default-ipv4-is-not-what-you-think-edb8ab154b10

 - name: Gather ansible_default_ipv4 from all hosts
   setup:
     gather_subset: '!all,network'
     filter: "ansible_default_ipv4"
   delegate_to: "{{ item }}"
   delegate_facts: yes
   when: hostvars[item].ansible_default_ipv4 is not defined
   loop: "{{ (groups['k8s_cluster'] | default([]) + groups['etcd'] | default([]) + groups['calico_rr'] | default([])) | unique }}"
   run_once: yes
   ignore_unreachable: true
+  ignore_errors: true
   tags: always

 - name: Create fallback_ips_base
   set_fact:
     fallback_ips_base: |
       ---
       {% for item in (groups['k8s_cluster'] | default([]) + groups['etcd'] | default([]) + groups['calico_rr'] | default([])) | unique %}
-      {% set found = hostvars[item].get('ansible_default_ipv4') %}
+      {% set found = hostvars[item].get('ansible_default_ipv4', {}) %}
       {{ item }}: "{{ found.get('address', '127.0.0.1') }}"
       {% endfor %}
   delegate_to: localhost
   connection: local
   delegate_facts: yes
   become: no
   run_once: yes

 - name: Set fallback_ips
   set_fact:
     fallback_ips: "{{ hostvars.localhost.fallback_ips_base | from_yaml }}"

PLAY [Prepare nodes for upgrade] ********************************************************************************************************************************************************************************

TASK [kubespray-defaults : Gather ansible_default_ipv4 from all hosts] ******************************************************************************************************************************************
ok: [k8s1.local] => (item=k8s1.local)
[WARNING]: Unhandled error in Python interpreter discovery for host k8s1.local: Failed to connect to the host via ssh: ssh: connect to host k8s3.local port 22: Connection timed out
failed: [k8s1.local -> k8s3.local] (item=k8s3.local) => {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}
ok: [k8s1.local -> k8s2.local] => (item=k8s2.local)
fatal: [k8s1.local -> {{ item }}]: UNREACHABLE! => {"changed": false, "msg": "All items completed", "results": [{"ansible_facts": {"ansible_default_ipv4": {"address": "10.88.111.29", "alias": "eth0", "broadcast": "10.88.111.255", "gateway": "10.88.111.254", "interface": "eth0", "macaddress": "bc:24:11:41:88:12", "mtu": 1500, "netmask": "255.255.252.0", "network": "10.88.108.0", "prefix": "22", "type": "ether"}, "discovered_interpreter_python": "/usr/bin/python3"}, "ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"fact_path": "/etc/ansible/facts.d", "filter": ["ansible_default_ipv4"], "gather_subset": ["!all", "network"], "gather_timeout": 10}}, "item": "k8s1.local"}, {"ansible_loop_var": "item", "item": "k8s3.local", "msg": "Data could not be sent to remote host \"k8s3.local\". Make sure this host can be reached over ssh: ssh: connect to host k8s3.local port 22: Connection timed out\r\n", "unreachable": true}, {"ansible_facts": {"ansible_default_ipv4": {"address": "10.88.111.30", "alias": "eth0", "broadcast": "10.88.111.255", "gateway": "10.88.111.254", "interface": "eth0", "macaddress": "bc:24:11:be:42:a6", "mtu": 1500, "netmask": "255.255.252.0", "network": "10.88.108.0", "prefix": "22", "type": "ether"}, "discovered_interpreter_python": "/usr/bin/python3"}, "ansible_loop_var": "item", "changed": false, "failed": false, "invocation": {"module_args": {"fact_path": "/etc/ansible/facts.d", "filter": ["ansible_default_ipv4"], "gather_subset": ["!all", "network"], "gather_timeout": 10}}, "item": "k8s2.local"}]}
...ignoring

TASK [kubespray-defaults : Create fallback_ips_base] ************************************************************************************************************************************************************
ok: [k8s1.local -> localhost]

TASK [kubespray-defaults : Set fallback_ips] ********************************************************************************************************************************************************************
ok: [k8s1.local]
ok: [k8s3.local]
ok: [k8s2.local]

TASK [Task that runs after] *************************************************************************************************************************************************************************************
ok: [k8s1.local] => {
    "fallback_ips": {
        "k8s1.local": "127.0.0.1",
        "k8s2.local": "127.0.0.1",
        "k8s3.local": "127.0.0.1"
    }
}
ok: [k8s3.local] => {
    "fallback_ips": {
        "k8s1.local": "127.0.0.1",
        "k8s2.local": "127.0.0.1",
        "k8s3.local": "127.0.0.1"
    }
}
ok: [k8s2.local] => {
    "fallback_ips": {
        "k8s1.local": "127.0.0.1",
        "k8s2.local": "127.0.0.1",
        "k8s3.local": "127.0.0.1"
    }
}

PLAY RECAP ******************************************************************************************************************************************************************************************************
k8s1.local                 : ok=4    changed=0    unreachable=0    failed=0    skipped=3    rescued=0    ignored=1
k8s2.local                 : ok=2    changed=0    unreachable=0    failed=0    skipped=2    rescued=0    ignored=0
k8s3.local                 : ok=2    changed=0    unreachable=0    failed=0    skipped=2    rescued=0    ignored=0

But as you can see, while it got past the early exit, it looks like it doesn't save the discovered facts. And so the output is all wrong. That's why I decided to first filter out the unreachable hosts in a separate task before running setup.

Does this PR introduce a user-facing change?:

None

k8s-ci-robot · 2024-03-13T00:49:22Z

Hi @Rickkwa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cyclinder · 2024-03-13T01:53:13Z

/ok-to-test

Rickkwa · 2024-04-12T21:49:47Z

Do you need any more info from me to move this forward? I'm hoping this can get into the 2.25 release, whenever that is.

k8s-ci-robot · 2024-06-26T13:58:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rickkwa
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* upgrade ansible version Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16 * Remove unused google cloud cloud_playbook * Fix dpkg_selection on non-existing packages Needed since ansible-core>2.16, see: ansible/ansible@f10d11b

Should make it easier to understand what's going on when testing locally and in CI.

…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>

…11021) Signed-off-by: KubeKyrie <[email protected]>

* Remove leftover files for Coreos Coreos was replaced by flatcar in 058438a but the file was copied instead of moved. * Remove workarounds for resolved ansible issues * boostrap: Use first_found to include per distro Using directly ID and VARIANT_ID with first_found allow for less manual includes. Distro "families" are simply handled by symlinks. * boostrap: don't set ansible_python_interpreter - Allows users to override the chosen python_interpreter with group_vars easily (group_vars have lesser precedence than facts) - Allows us to use vars at the task scope to use a virtual env Ansible python discovery has improved, so those workarounds should not be necessary anymore. Special workaround for Flatcar, due to upstream ansible not willing to support it.

…ubernetes-sigs#10999) Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

…netes-sigs#11035)

* Move fedora ansible python install to bootstrap-os * /bin/dir is set in bootstrap-os * Removing ansible_os_family workarounds Support for these distributions was merged in Ansible, no need to override it ourselves now. ansible/ansible#69324 openEuler ansible/ansible#77275 UnionTech OS Server 20 ansible/ansible#78232 Kylin * Don't unconditionnaly set VARIANT_ID=coreos in os-release WTF, this is so wrong. Furthermore, is_fedora_coreos is already handled in boostrap-os * Handle Clearlinux generically Followup of 4eec302 (since we're using package module anyway, let's get rid of the custom task)

…s-sigs#11292)

Signed-off-by: tico88612 <[email protected]>

Signed-off-by: tu1h <[email protected]>

Signed-off-by: Kay Yan <[email protected]>

…ize vars (kubernetes-sigs#10943)

Signed-off-by: Kay Yan <[email protected]>

Signed-off-by: bo.jiang <[email protected]>

Signed-off-by: Kay Yan <[email protected]>

…netes-sigs#11303)

Signed-off-by: tu1h <[email protected]>

… start with linux- on Ubuntu (kubernetes-sigs#11296) Signed-off-by: tu1h <[email protected]>

Signed-off-by: serge Hartmann <[email protected]>

kubernetes-sigs#11169) * add the ability to configure extra args to the different cinder-csi-plugin containers * endfor block added to be syntactically correct jinja

) Signed-off-by: tico88612 <[email protected]>

The pull request adding the pre-commit hook config was merged.

k8s-ci-robot · 2024-06-26T22:44:57Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

77cc749 Bump tox from 4.11.3 to 4.15.0 (Bump tox from 4.11.3 to 4.15.0 #11133)
7d0e887 Bump jinja2 from 3.1.2 to 3.1.3 (Bump jinja2 from 3.1.2 to 3.1.3 #11119)
ad95947 Bump molecule-plugins[vagrant] from 23.5.0 to 23.5.3 (Bump molecule-plugins[vagrant] from 23.5.0 to 23.5.3 #11120)
688a0c7 Bump tzdata from 2023.3 to 2024.1 (Bump tzdata from 2023.3 to 2024.1 #11121)
74405ce Bump netaddr from 0.9.0 to 1.2.1 (Bump netaddr from 0.9.0 to 1.2.1 #11148)
cc245e6 Bump ansible from 9.3.0 to 9.5.1 (Bump ansible from 9.3.0 to 9.5.1 #11157)
1d0a09f Bump ruamel-yaml from 0.18.5 to 0.18.6 (Bump ruamel-yaml from 0.18.5 to 0.18.6 #11147)
89ff14f Bump jinja2 from 3.1.3 to 3.1.4 (Bump jinja2 from 3.1.3 to 3.1.4 #11166)
c59e9ca Bump ansible-lint from 6.22.2 to 24.2.3 (Bump ansible-lint from 6.22.2 to 24.2.3 #11151)
e3145c0 Bump pytest-testinfra from 9.0.0 to 10.1.0 (Bump pytest-testinfra from 9.0.0 to 10.1.0 #11149)
b5e8b78 Bump molecule from 6.0.2 to 24.2.1 (Bump molecule from 6.0.2 to 24.2.1 #11150)
997d1b7 Bump markupsafe from 2.1.3 to 2.1.5 (Bump markupsafe from 2.1.3 to 2.1.5 #11176)
4e02645 Bump yamllint from 1.32.0 to 1.35.1 (Bump yamllint from 1.32.0 to 1.35.1 #11177)
bc1085c Bump cryptography from 41.0.4 to 42.0.7 (Bump cryptography from 41.0.4 to 42.0.7 #11187)
d8d1850 Bump ara[server] from 1.7.0 to 1.7.1 (Bump ara[server] from 1.7.0 to 1.7.1 #11178)
7f0b927 Bump pbr from 5.11.1 to 6.0.0 (Bump pbr from 5.11.1 to 6.0.0 #11188)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Rickkwa · 2024-06-26T22:45:30Z

Gah, I'm bad at rebasing. Let me re-open a new one.

k8s-ci-robot · 2024-06-26T22:45:40Z

@Rickkwa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubespray-yamllint	`499b395`	link	true	`/test pull-kubespray-yamllint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fallback_ips: Gather facts from reachable hosts only

f41f1b5

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2024

k8s-ci-robot requested review from cyclinder and mzaian March 13, 2024 00:49

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2024

k8s-ci-robot added the do-not-merge/contains-merge-commits label Jun 26, 2024

VannTen and others added 16 commits June 26, 2024 18:42

Fix ansible python version range (kubernetes-sigs#11009)

2048dd3

Show log on vagrant (kubernetes-sigs#10958)

34c03a5

Should make it easier to understand what's going on when testing locally and in CI.

Cleanup unused CI tooling (kubernetes-sigs#11014)

8a394a0

spelling: scrapper -> scraper (kubernetes-sigs#11015)

cde9212

fix: config hostname as string type in kubeadmConf rendering (kuberne…

7306b87

…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>

Add kubelet_cpu_manager_policy_options (kubernetes-sigs#11023)

90f8884

Make proxy protocol in upcloud LB configurable (kubernetes-sigs#10971)

0e58515

make kube-vip LeaderElection variables configurable (kubernetes-sigs#…

ae6c3af

…11021) Signed-off-by: KubeKyrie <[email protected]>

kubespray-defaults: regenerate checksums and bump various versions (k…

1130a5a

…ubernetes-sigs#10999) Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

[kubernetes] Add hashes for kubernetes 1.29.3, 1.28.8, 1.27.12 (kuber…

656c955

…netes-sigs#11035)

Change hard-coded URLs to use variables (kubernetes-sigs#11031)

cb88a80

configure crio to use kube reserved cgroups (kubernetes-sigs#11028)

86e07c1

[etcd] make etcd 3.5.12 default

3963b6d

ant31 and others added 20 commits June 26, 2024 18:42

CI: switch to unprivileged Kaniko to build pipeline images (kubernete…

f77aa4c

…s-sigs#11292)

Feat: upgrade cert-manager from 1.13.2 to 1.13.6 (kubernetes-sigs#11279)

f1fcd99

Signed-off-by: tico88612 <[email protected]>

Add options to control images pulling of kubelet (kubernetes-sigs#11094)

586dc7f

Signed-off-by: tu1h <[email protected]>

fix openstack cleanup (kubernetes-sigs#11299)

cb816d4

Signed-off-by: Kay Yan <[email protected]>

add cilium_hubble_event_buffer_capacity & cilium_hubble_event_queue_s…

986db11

…ize vars (kubernetes-sigs#10943)

add step for k8s upgrade on release process (kubernetes-sigs#11321)

f0e505d

Signed-off-by: Kay Yan <[email protected]>

update docker cli version for ubuntu (kubernetes-sigs#11291)

73f363e

Signed-off-by: bo.jiang <[email protected]>

Fix broken links in the cilium doc (kubernetes-sigs#11318)

196fad5

Update Vagrantfile: fix path for vagrant.md (kubernetes-sigs#11306)

43e9b3e

fix-ci-packet_centos7-calico-ha-once-localhost (kubernetes-sigs#11315)

6c50b61

Signed-off-by: Kay Yan <[email protected]>

fix task Set label to node (kubernetes-sigs#11307)

b4052c4

upcloud: v5.6.0 and better server groups (kubernetes-sigs#11311)

be9e5b4

Upgrade upcloud csi driver to v1.1.0 and add snapshot features (kuber…

4d85413

…netes-sigs#11303)

Bump docker_containerd to 1.6.32 (kubernetes-sigs#11293)

71a9a45

Signed-off-by: tu1h <[email protected]>

Support disable unattended-upgrades for Linux kernel and all packages…

e8cfbc9

… start with linux- on Ubuntu (kubernetes-sigs#11296) Signed-off-by: tu1h <[email protected]>

dependencies for kubelet.service (kubernetes-sigs#11297)

4348801

Signed-off-by: serge Hartmann <[email protected]>

add ingress controller admission svc (kubernetes-sigs#11309)

b6538b5

add the ability to configure extra args to the different cinder-csi-p… (

8d7572c

kubernetes-sigs#11169) * add the ability to configure extra args to the different cinder-csi-plugin containers * endfor block added to be syntactically correct jinja

Bump CNI weave 2.8.1 to 2.8.7 (community version) (kubernetes-sigs#11228

0c045bb

) Signed-off-by: tico88612 <[email protected]>

Switch back pre-commit hook misspell to upstream (kubernetes-sigs#11280)

499b395

The pull request adding the pre-commit hook config was merged.

Rickkwa force-pushed the 10993-fallback-ips branch from f8c42aa to 499b395 Compare June 26, 2024 22:44

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 26, 2024

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/contains-merge-commits size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2024

Rickkwa closed this Jun 26, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fallback_ips: Gather facts from reachable hosts only #11006

fallback_ips: Gather facts from reachable hosts only #11006

Rickkwa commented Mar 13, 2024

k8s-ci-robot commented Mar 13, 2024

cyclinder commented Mar 13, 2024

Rickkwa commented Apr 12, 2024

k8s-ci-robot commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024

Rickkwa commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024

fallback_ips: Gather facts from reachable hosts only #11006

fallback_ips: Gather facts from reachable hosts only #11006

Conversation

Rickkwa commented Mar 13, 2024

k8s-ci-robot commented Mar 13, 2024

cyclinder commented Mar 13, 2024

Rickkwa commented Apr 12, 2024

k8s-ci-robot commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024

Rickkwa commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024