[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KubeKyrie
Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

One question is that crictl is not yet a complete replacement for ctr due to a known issue #10670, as this PR ci failure shows.

And on the other hand, crictl does not support load/save image.

@yankay @VannTen @mzaian Could u give some help please?
Thanks.

One question is that crictl is not yet a complete replacement for ctr due to a known issue #10670, as this PR ci failure shows.
The CI shows nerdctl failing, so not sure of the relation ? ```

As discussed in #10907, we use crictl uniformly to pull images.
But just as this CI failure shows:
we first pull image by

crictl pull quay.m.daocloud.io/kubespray/k8s-netchecker-server:v1.2.2

then image save

nerdctl -n k8s.io image save -o  xxx.tar quay.m.daocloud.io/kubespray/k8s-netchecker-server:v1.2.2

an error occurs:

FATA[0000] failed to get reader: content digest sha256:16708e34354589f10d0f402e59f7251e0a685a98c1497dffbd84cce4a11a62d6: not found

This is a known issue #10670, and workaround way is to use ctr to pull image. So I am not sure how to handle it.

Can convert all save/load image operations to only use skopeo ?

- name: Set image save/load command for docker
  set_fact:
    image_save_command: "{{ docker_bin_dir }}/docker save {{ image_reponame }} | gzip -{{ download_compress }} > {{ image_path_final }}"
    image_load_command: "{{ docker_bin_dir }}/docker load < {{ image_path_final }}"
  when: container_manager == 'docker'

- name: Set image save/load command for containerd
  set_fact:
    image_save_command: "{{ bin_dir }}/nerdctl -n k8s.io image save -o {{ image_path_final }} {{ image_reponame }}"
    image_load_command: "{{ bin_dir }}/nerdctl -n k8s.io image load < {{ image_path_final }}"
  when: container_manager == 'containerd'

- name: Set image save/load command for crio
  set_fact:
    image_save_command: "{{ bin_dir }}/skopeo copy containers-storage:{{ image_reponame }} docker-archive:{{ image_path_final }} 2>/dev/null"
    image_load_command: "{{ bin_dir }}/skopeo copy docker-archive:{{ image_path_final }} containers-storage:{{ image_reponame }} 2>/dev/null"
  when: container_manager == 'crio'

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-triage-robot: Closed this PR.