-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert usages of nerdctl and crt to crictl #10907
Comments
As far as I know |
Yeah and I just saw it's required by kubeadm anyway, so that's the obvious candidate |
Yes! Could it be a breaking change during next upgrade for some users? |
That would not be breaking per se (meaning it would not break kubespray itself regardless of inventories, since we would get the cri frontend chosen regardless of what was there before), but if users rely on one of the three specifically, it won't be updated.
|
/good-first-issue |
@VannTen: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There are significant documents to describe the difference between For kubespray, using the As notice: 1: If the var setting is:
The
|
Could I try to work on this? |
Go ahead !
|
What would you like to be added
We currently use (AFAICT):
If possible, we should use only one CRI frontend for manipulating images and containers.
Why is this needed
crictl_image_pull_command
, etc)Not sure what the pros and cons of each are. ctr looks more minimal, maybe that's enough for what we need to do in Kubespray ?
wdyt @yankay @mzaian @floryut @MrFreezeex ?
EDIT: We'll use crictl as it's required by kubeadm, and compatible with all container runtime.
Usage sites can be converted by small batch, then once the conversion is done we'll be able to remove the download of nerdctl and ctr.
The text was updated successfully, but these errors were encountered: