Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubespray 2.23.2 did not update kube_version in contrib/kubespray/inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml #10803

Open
jeanfabrice opened this issue Jan 17, 2024 · 4 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@jeanfabrice
Copy link
Contributor

What happened?

  • Upgrading my local repo with kubespray 2.23.2
  • Generating a diff on inventory/sample: git diff v2.23.1..v2.23.2 -- inventory/sample so I can patch my own inventory with a 3-way patch
  • Found that contrib/kubespray/inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml is still referencing kube_version: v1.27.7 despite Release Notes (and kubespray-defaults role code) indicate Kubespray 2.23.2 to use Kubernetes v1.27.9:
$ sudo git diff v2.23.1..v2.23.2 -- roles/kubespray-defaults/defaults/main.yaml
diff --git a/roles/kubespray-defaults/defaults/main.yaml b/roles/kubespray-defaults/defaults/main.yaml
index 17b37a0ed..b7fa6991a 100644
--- a/roles/kubespray-defaults/defaults/main.yaml
+++ b/roles/kubespray-defaults/defaults/main.yaml
@@ -16,7 +16,7 @@ kubelet_fail_swap_on: true
 kubelet_swap_behavior: LimitedSwap
 
 ## Change this to use another Kubernetes version, e.g. a current beta release
-kube_version: v1.27.7
+kube_version: v1.27.9
 
 ## The minimum version working
 kube_version_min_required: v1.25.0

What did you expect to happen?

contrib/kubespray/inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml to show kube_version: v1.27.9

How can we reproduce it (as minimally and precisely as possible)?

Create a Kubespray 2.23.2 cluster with the default inventory sample should create a Kubernetes v1.27.7 cluster (as inventory group vars take over default roles variables)

OS

unrelated I think
Ansible is running on MacOS Sonoma.
Kubernetes cluster is running on Ubuntu 22.04.3 LTS / Linux 5.15.0-91-generic x86_64

Version of Ansible

$ ansible --version                               git:(v2.23.2|⚑2) 
ansible [core 2.14.11]
  config file = /Users/jeanfabrice/Personal/Homelab/contrib/kubespray/ansible.cfg
  configured module search path = ['/Users/jeanfabrice/Personal/Homelab/contrib/kubespray/library']
  ansible python module location = /Users/jeanfabrice/.virtualenvs/homelab/lib/python3.9/site-packages/ansible
  ansible collection location = /Users/jeanfabrice/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/jeanfabrice/.virtualenvs/homelab/bin/ansible
  python version = 3.9.18 (main, Oct 16 2023, 07:38:39) [Clang 15.0.0 (clang-1500.0.40.1)] (/Users/jeanfabrice/.virtualenvs/homelab/bin/python)
  jinja version = 3.1.2
  libyaml = True

Version of Python

Python 3.9.18

Version of Kubespray (commit)

ca271b8

Network plugin used

calico

Full inventory with variables

No response

Command used to invoke ansible

No response

Output of ansible run

No response

Anything else we need to know

No response

@jeanfabrice jeanfabrice added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2024
@yankay
Copy link
Member

yankay commented Jan 18, 2024

Thanks @jeanfabrice

@yankay yankay added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 18, 2024
@prashantrewar
Copy link

/assign

@VannTen
Copy link
Contributor

VannTen commented Jan 18, 2024

Related #10697

@VannTen
Copy link
Contributor

VannTen commented Feb 12, 2024

/remove-kind bug
/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants