Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spring AOT model relfection (Issue #3271) #3277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rj93
Copy link

@rj93 rj93 commented Apr 3, 2024

Partially fixes #3271

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rj93
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Apr 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rj93 / name: Richard Jones (00c9a40)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 3, 2024
@yue9944882
Copy link
Member

👀 close and re-open the PR to trigger CI job

@yue9944882 yue9944882 closed this May 27, 2024
@yue9944882 yue9944882 reopened this May 27, 2024
@rj93
Copy link
Author

rj93 commented Jun 5, 2024

@yue9944882 is there anything I can do to move this PR along? I've reviewed the failed build, but it doesn't appear to be anything to do with my change (and I assume it doesn't even test graalvm native but I could be wrong), so not sure what is happening there.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2024
@cache-sk
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@brendandburns brendandburns reopened this Dec 5, 2024
@brendandburns
Copy link
Contributor

close/re-open to trigger CI/CD. If tests are still failing, they need to be fixed in order for this to merge.

@cache-sk
Copy link

cache-sk commented Dec 5, 2024

@brendandburns Just reminder - this PR may not be necessary, please regenerate model before merging, if kubernetes-client/gen#270 did not fix these AOT issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when compiled to Spring Native binary
6 participants