Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing with Zipkin doesn't appear to work #1098

Closed
benmoss opened this issue Jul 15, 2021 · 2 comments
Closed

Tracing with Zipkin doesn't appear to work #1098

benmoss opened this issue Jul 15, 2021 · 2 comments
Assignees
Labels
area/data-plane kind/bug Categorizes issue or PR as related to a bug. triage/needs-user-input Issues which are waiting on a response from the reporter

Comments

@benmoss
Copy link
Contributor

benmoss commented Jul 15, 2021

Describe the bug
Tracing support doesn't appear to be working

Expected behavior
I've configured my broker with the sample configs from eventing to have a Zipkin service running in knative-eventing and a config-tracing that forwards with a sample-rate of 1.0.

I configured the dispatcher to log at DEBUG level and see these lines in the logs:

{"@timestamp":"2021-07-15T15:37:07.873Z","@version":"1","message":"Registering tracing configurations backend=ZIPKIN sampleRate=1.0 loggingDebugEnabled=true","logger_name":"dev.knative.eventing.kafka.broker.core.tracing.TracingConfig","thread_name":"main","level":"INFO","level_value":20000,"backend":"ZIPKIN","sampleRate":1.0,"loggingDebugEnabled":true}
{"@timestamp":"2021-07-15T15:37:07.972Z","@version":"1","message":"Add Zipkin simple processor","logger_name":"dev.knative.eventing.kafka.broker.core.tracing.TracingConfig","thread_name":"main","level":"DEBUG","level_value":10000}

So it looks like it's picking up the config, but I don't see any traces being emitted in my Zipkin instance. I have a simple heartbeat source emitting to an event-display service, nothing fancy.

I tried using ksniff to inspect packets coming out of the dispatcher and confirmed there's nothing going out to the zipkin server.

To Reproduce
Configure tracing, see if it works at all?

Knative release version
0.24

Additional context
knative/eventing#5589 reports that it's not working with Jaeger as well

@benmoss benmoss added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2021
@pierDipi pierDipi self-assigned this Jul 15, 2021
@pierDipi
Copy link
Member

pierDipi commented Jul 17, 2021

I see them:

image

Just a couple of notes:

@pierDipi pierDipi added the triage/needs-user-input Issues which are waiting on a response from the reporter label Jul 17, 2021
@benmoss
Copy link
Contributor Author

benmoss commented Jul 19, 2021

Ah, I think I was under the impression that it would be generated if not present. Thanks for the follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane kind/bug Categorizes issue or PR as related to a bug. triage/needs-user-input Issues which are waiting on a response from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants