Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a provider does not clean up the changes on the infrastructure #392

Open
PeterSzegedi opened this issue Oct 9, 2023 · 1 comment · May be fixed by #2871
Open

Deleting a provider does not clean up the changes on the infrastructure #392

PeterSzegedi opened this issue Oct 9, 2023 · 1 comment · May be fixed by #2871
Assignees
@skynetigor
Labels
Enhancement New feature or request Feature A new feature

Comments

@PeterSzegedi
Copy link

Is your feature request related to a problem? Please describe.
The delete provider option does not undo the changes or recommends you info about how to undo them. Say you add subscriptions to your sns topics, they will stay there and keep sending data to keep.

Describe the solution you'd like
Either clean up the changes done, or recommend actions to clean up
@talboren talboren added Enhancement New feature or request Feature A new feature labels Oct 9, 2023
@talboren talboren mentioned this issue Oct 15, 2024
Open
@skynetigor skynetigor self-assigned this Dec 18, 2024
@skynetigor skynetigor linked a pull request Dec 18, 2024 that will close this issue
Open
4 tasks
@skynetigor
Copy link

Hi @PeterSzegedi
I recently added infra to enable providers to clean up their subscriptions/webhooks/etc.
But since each provider requires specific clean up logic, for now I only implemented webhook removal for PagerDuty.
Please take a look at my PR if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skynetigor skynetigor

Labels
Enhancement New feature or request Feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add infra for cleaning up providers when deleted keephq/keep
3 participants
@PeterSzegedi @skynetigor @talboren