Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[➕ Feature]: Split between alert ingestion and workflow execution #2839

Open
shahargl opened this issue Dec 16, 2024 · 0 comments
Open

[➕ Feature]: Split between alert ingestion and workflow execution #2839

shahargl opened this issue Dec 16, 2024 · 0 comments
Labels
Feature A new feature

Comments

@shahargl
Copy link
Member

  1. Currently, the workflow execution and alert ingestion are tightly coupled
  2. This means it is hard to "restart" a workflow because currently, it means you need to trigger the alert again
  3. It also uses insert_events which is "one to many" and can trigger other workflows

What we want to do:

  1. Add "re-run workflow" without ingesting the alert again.
  2. Similar to GitHub action restart workflow

Implementation (IMO)

  1. Refactor WorkflowManager to have a clear interface
  2. WorkflowManager should have restart_workflow(workflow_id, workflow_execution_id) that "knows" all the context from the workflow_execution_id so it can be restarted
@dosubot dosubot bot added the Feature A new feature label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
None yet
Development

No branches or pull requests

1 participant