Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic dependency with github.com/kcp-dev/client-go #75

Open
p0lyn0mial opened this issue Dec 14, 2022 · 1 comment
Open

cyclic dependency with github.com/kcp-dev/client-go #75

p0lyn0mial opened this issue Dec 14, 2022 · 1 comment

Comments

@p0lyn0mial
Copy link
Contributor

generated code in github.com/kcp-dev/code-generator/examples has a dependency on
github.com/kcp-dev/client-go/tree/main/third_party/k8s.io/client-go

when changes to kcp-dev/client-go repository also require to generate some code we need a corresponding code-generator (https://github.com/kcp-dev/client-go/blob/main/Makefile#L26) which might lead to a dead end.

In my case I had made a change to kcp-dev/client-go/third_party which is required by code-generator/examples and kcp-dev/client-go/informers (kcpinformers "github.com/kcp-dev/apimachinery/third_party/informers")

@p0lyn0mial
Copy link
Contributor Author

/cc @stevekuznetsov @ncdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant