Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generator code #4

Open
varshaprasad96 opened this issue May 4, 2022 · 0 comments
Open

Refactor generator code #4

varshaprasad96 opened this issue May 4, 2022 · 0 comments

Comments

@varshaprasad96
Copy link
Contributor

varshaprasad96 commented May 4, 2022 •
edited
Loading

Currently, the project uses declares flags in a separate package, whose values need to be copied to the generator. An alternative approach would be:

  • Remove flag package
  • Rename Flags struct to Options
  • Move Options struct into pkg/generator
  • Bind flags directly to an Options instance
  • Have the Generator work directly against Options (to avoid having to copy)
  • Simplify package path for the generator: Clientset wrapper for kcp #1 (comment)

Note: These options need to be passed down to all the generators.
@varshaprasad96 varshaprasad96 changed the title Refactor generator Refactor generator code May 4, 2022
@varshaprasad96 varshaprasad96 mentioned this issue May 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varshaprasad96